forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Casper on August 23, 2004, 01:11:36 pm

Title: Versioncheck creating multiple errors on server
Post by: Casper on August 23, 2004, 01:11:36 pm

I have a total of 5 installs, 3 on 1 server, 2 on another.  The 3, which include both version 1.3 and 1.4 work well, but the 2 installs on the other server, both 1.4 have errors, best illustrated by the attached screenshot.

Cannot find the cause, and there is no debug info given by the page.

Title: Re: Versioncheck creating multiple errors on server
Post by: Joachim Müller on August 24, 2004, 09:32:20 am

Hey Casper,

I think this is being caused by the php version on the server with errors is smaller than 4.2.0, this is what the manual (http://www.php.net/pow) says:

Quote

pow
(PHP 3, PHP 4 , PHP 5)

pow -- Exponential expression
Description
number pow ( number base, number exp)


Returns base raised to the power of exp. If possible, this function will return an integer.

If the power cannot be computed, a warning will be issued, and pow() will return FALSE. Since PHP 4.2.0 pow() doesn't issue any warning.

Basically, this is poorly coded (sorry) :-[ - could you check by replacing

Code: [Select]

$return = $return + (pow('100',count($version_info)-$i)*$version_info[$i]);with

Code: [Select]

$power = @pow('100',count($version_info)-$i)*$version_info[$i];
$return = $return + $power;and report back (as I don't have an older version of php to test this with)?

GauGau

Title: Re: Versioncheck creating multiple errors on server
Post by: Casper on August 24, 2004, 11:53:15 am

Hi Gaugau,

that worked great. Tested on both my servers.  I have fixed and committed both stable and dev versions.