forum.coppermine-gallery.net

Support => cpg1.3.x Support => Older/other versions => cpg1.3 Miscellaneous => Topic started by: tk_jkpg on June 23, 2004, 06:36:17 pm

Title: Possible mistake in lang file?
Post by: tk_jkpg on June 23, 2004, 06:36:17 pm

While working on swedish translation for 1.3.0 i have found possible error. I think that the variable 'err_fsize_too_large' should warn about filesize and not image dimensions as both english and swedish(1.2) do. It seems to be confused/mixed with 'err_imgsize_too_large' that should be about image dimensions. Se text below.

/Tommy


Some text from the english.php file:
// ------------------------------------------------------------------------- //
// File db_input.php
// ------------------------------------------------------------------------- //

if (defined('DB_INPUT_PHP')) $lang_db_input_php = array(
.
.
  'err_fsize_too_large' => 'The size of file you have uploaded is too large (maximum allowed is %s x %s) !', //cpg1.3.0
  'err_imgsize_too_large' => 'The size of the file you have uploaded is too large (maximum allowed is %s KB) !',
.
.

Title: Re: Possible mistake in lang file?
Post by: Nibbler on June 23, 2004, 07:38:54 pm

I agree the names are a little ambigous, but the error messages are correct.

Title: Re: Possible mistake in lang file?
Post by: Casper on June 23, 2004, 07:49:19 pm

I think the error messages are wrong.
Too large filesize ends '%s x %s'
Too large pixel ends '%s kb'

BUT, when are these error messages used.  upload.php uses the (correct) messages from lang_upload not lang_db_input

Title: Re: Possible mistake in lang file?
Post by: Nibbler on June 23, 2004, 08:06:50 pm

True, these language entries are made redundant by the new upload system.

Title: Re: Possible mistake in lang file?
Post by: Joachim Müller on June 25, 2004, 01:15:40 am

I suggest we keep them for the moment, I'll flag them in the cvs for deletion once upload.php has gone through all necessary changes.

GauGau