forum.coppermine-gallery.net

No Support => Feature requests => Topic started by: silly_walk on August 31, 2006, 08:59:13 pm

Title: Table header should not be used for areas the size of paragraphs or lists
Post by: silly_walk on August 31, 2006, 08:59:13 pm

The tags that include "tableh" and its variants are not only used for headers (Sort my Albums, as an example), which makes it hard to skin properly, because the headers look great until you run into a part of the gallery where there is not actually a header but that uses the header tag (the screen where you place uploaded pics is another example). These areas should be re-I.D.ed / re-classed.

Title: Re: Table header should not be used for areas the size of paragraphs or lists
Post by: Joachim Müller on September 01, 2006, 08:44:20 am

Valid request. Could you come up with some code examples, where the tablehX classes are being used in places they're not suppossed to?

Title: Re: Table header should not be used for areas the size of paragraphs or lists
Post by: silly_walk on September 01, 2006, 05:21:41 pm

From upload.php:

Code: [Select]

    // Create image tag and echo it to the output buffer.
    echo "<tr><td class=\"tableh2\"><img class=\"image\" src=\"".$path_to_preview."\"  /></td>";

    // Echo instructions.
    echo "<td class=\"tableh2\">{$lang_upload_php['picture']} - {$file_set[0]}<br /><br />{$lang_upload_php['place_instr_1']}<br /><br />";
From groupmgr.php:

Code: [Select]

    while ($group = mysql_fetch_array($result)) {
        $group['group_name'] = $group['group_name'];
        $row_counter++;
        if ($row_counter == 1 ) {$table_background = 'tableb';}else{$table_background = 'tableh2';$row_counter = 0;}