forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Pastinakel on August 08, 2006, 10:39:50 pm

Title: Fix for xp publish "binary" reg file for lang/dutch.php users
Post by: Pastinakel on August 08, 2006, 10:39:50 pm
The problem
When using xp_publish.php to download and merge the needed reg file XP complains about the text file not in binary. Examining the downloaded regfile I noticed some garbage characters at the beginning of that file:
Quote
Windows Registry Editor Version 5.00
Those first three characters made Xp very unhapy.

The search
At first I thought it had to do something with headers so I took a journey through various headers and content-types. No result. At last I added a
Quote
echo "bla";
to xp_publish and moved the line downwards and after every move I refreshed xp_publish.php in my browser to see if the
Quote
bla
had changed to
Quote
bla
After a change I repeated the same process with the file that was included when the above change happened. This pinned the error down to:

The cause
lang/dutch.php  >:(

The fix
Change the first line in lang/dutch.php from
Quote
<?php
to
Quote
<?php

xp_publish.php looks better now and the regfile works with XP. XP is very happy now ;D
Title: Re: Fix for xp publish "binary" reg file for lang/dutch.php users
Post by: Joachim Müller on August 08, 2006, 10:44:23 pm
What's your coppermine version?
Title: Re: Fix for xp publish "binary" reg file for lang/dutch.php users
Post by: Pastinakel on August 08, 2006, 10:49:37 pm
What's your coppermine version?
Coppermine Photo Gallery 1.4.8 (stable)

Sorry I didn't mention that. Maybe it was fixed in a newer build but I didn't find anything about a fix on this forum. There are 2 threads that mention this problem but is was not fixed: XP Plublishing reg file (help needed) (http://forum.coppermine-gallery.net/index.php?topic=14542.0) and XP_publish.php - The specified file is not a registry script (http://forum.coppermine-gallery.net/index.php?topic=8717.0)
Title: Re: Fix for xp publish "binary" reg file for lang/dutch.php users
Post by: Nibbler on August 09, 2006, 01:00:02 am
Committed fix to dutch lang file.