forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: danuvius on June 23, 2006, 02:40:33 pm

Title: Bug in function create_tabs() in functions.inc.php (in 1.4.8)
Post by: danuvius on June 23, 2006, 02:40:33 pm

During making the Blix Theme I found the following bug. I added the function theme_create_tabs in my theme.php and my tabs dissapeared so after a few minute I found the following bug in include/functions.inc.php. Solution:

Line 472 change

Code: [Select]

        if (function_exists('theme_create_tabs')) {
            theme_create_tabs($items, $curr_page, $total_pages, $template);
                return;
        }
into:

Code: [Select]

        if (function_exists('theme_create_tabs')) {
            return theme_create_tabs($items, $curr_page, $total_pages, $template);
        }


Title: Re: Bug in function create_tabs() in functions.inc.php (in 1.4.8)
Post by: Paver on June 23, 2006, 02:47:23 pm

You are correct.  I didn't notice that when I was looking at that function some time ago.

In analogy with the rest of the function, do you think it should be instead:

Code: [Select]

        if (function_exists('theme_create_tabs')) {
            $tabs = theme_create_tabs($items, $curr_page, $total_pages, $template);
            return $tabs.$template['tab_trailer'];
        }
Hmm... maybe not.   It should be up to the theme coder to decide what should be displayed.

Moving to bugs board.

Title: Re: Bug in function create_tabs() in functions.inc.php (in 1.4.8)
Post by: Paver on June 26, 2006, 07:10:50 am

Original fix proposed by danuvius committed to stable & devel.  Will be in next version (1.4.9).

Title: Re: Bug in function create_tabs() in functions.inc.php (in 1.4.8)
Post by: Yetio on August 22, 2006, 05:20:04 pm

Thanks a lot... it is working fine now...  :)
Do you also have an easy solution for the film strip?

Title: Re: Bug in function create_tabs() in functions.inc.php (in 1.4.8)
Post by: Joachim Müller on August 23, 2006, 06:22:13 am

This is not a support thread. You mustn't ask questions here, particularly not ask unrelated questions.