forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: doggystyle on May 22, 2006, 02:15:11 pm

Title: Broken link in filmstrip for "lastuploaded by" meta albums
Post by: doggystyle on May 22, 2006, 02:15:11 pm
I get a "No Image to display" when i click a specific way regarding the "latest uploads" function and i don't think that it used to be so.

Clickpath to the demo gallery at the coppermine site:

Nature => a username (to get the profile) => last uploaded file.... => a picture => one of the thumbnail under the displayed picture => "No image to display" ????


greets

doggy

[edit GauGau]
Renamed thread from "Bug or feature?" to "Broken link in filmstrip for "lastuploaded by" meta albums"
[/edit]
Title: Re: Bug or feature?
Post by: Vargha on May 22, 2006, 02:50:44 pm
check the groups permissions for viewing the pictures
Title: Re: Bug or feature?
Post by: doggystyle on May 22, 2006, 03:11:37 pm
the strange thing is, when you click another way, you can see the pictures.

Another example with the Pics "terra" and "Supernove" from gaugau:

Last uploads => terra => one of the thumbs below ( i.e. the red one "supernova") => all ok

now the way with the profile. you can continue at the supernova site:

gaugau (inside the file information) => Last uploaded file.Click to see all uploads by gaugau => terra => one of the thumbs (i.e. supernova) => no image to display

or try to open the allready shown up terra with a click at the left thumb....same error

hmmm, i think the uid is missing in the url for the thumbs.
Title: Re: Bug or feature?
Post by: Vargha on May 22, 2006, 04:24:23 pm
may i see your coppermine url
Title: Re: Bug or feature?
Post by: Joachim Müller on May 22, 2006, 07:11:32 pm
hehe, the blind leading the seeing ;D

Vargha, we appreciate your readiness to help, but this is out of your league. Doggystyle has discovered a bug - there's no need to see his site, as you can clearly replicate that the thing he's reporting happens on our demo.

When clicking on a filmstrip thumb on http://coppermine-gallery.net/demo/cpg14x/displayimage.php?album=lastupby&cat=0&pos=1&uid=26300, there is an unexpected error.

Moving to bugs board.
Title: Re: Broken link in filmstrip for "lastuploaded by" meta albums
Post by: Nibbler on May 22, 2006, 09:10:15 pm
classic has a custom theme_display_film_strip() so missed out on the uid bug fix.
Title: Re: Broken link in filmstrip for "lastuploaded by" meta albums
Post by: Abbas Ali on May 23, 2006, 09:26:25 am
Don't forget the sample theme too ;).
Title: Re: Broken link in filmstrip for "lastuploaded by" meta albums
Post by: Joachim Müller on June 05, 2006, 02:11:18 pm
@devs: Could the custom theme_display_film_strip in the classic theme be removed?
Title: Re: Broken link in filmstrip for "lastuploaded by" meta albums
Post by: Paver on June 05, 2006, 06:36:43 pm
How did that function get into the classic theme?  I don't remember its being there last time I checked, which might be 2-3 versions or so ago.  Looking at the logs it's not clear.  It looks like there are a lot of revisions without log notes, if I understand the log correctly (and looking at a unified diff here & there).
Title: Re: Broken link in filmstrip for "lastuploaded by" meta albums
Post by: Nibbler on June 05, 2006, 09:21:22 pm
Judging by svn, seems to have been an accidental commit by donnoman while modifying the ordering of tags inside the template.html for a bunch of themes. (revision 2688: Moved title to be below the declaration of the charset).
Title: Re: Broken link in filmstrip for "lastuploaded by" meta albums
Post by: Paver on June 05, 2006, 10:13:21 pm
Ah yes, there it is.  I guess I don't understand the revision numbering.  I'll read more about SVN to figure things out. 

I don't mean to blame anyone - just thought this would be a good (clean) example or "problem for the student" to track down changes.
Title: Re: Broken link in filmstrip for "lastuploaded by" meta albums
Post by: Nibbler on June 05, 2006, 10:35:33 pm
Quote from: Paver on June 05, 2006, 10:13:21 pm
I don't mean to blame anyone

Why not? it's just the command you need to answer such questions ;)

I'll remove the code, it saves me adding the fix.
Title: Re: Broken link in filmstrip for "lastuploaded by" meta albums
Post by: doggystyle on June 07, 2006, 08:14:11 am
sounds, this won't help me with the custom orange theme. if you have a fix ready, it would be nice to post it here.

thx

doggy
Title: Re: Broken link in filmstrip for "lastuploaded by" meta albums
Post by: Paver on July 01, 2006, 05:44:12 am
The sample theme drifted away from the a snapshot of themes.inc.php and so did not include certain bug fixes, like the one described in this thread (having to do with $uid_link and the GET parameter "uid").

The sample theme is now re-synced and has been committed to SVN 'stable'.  It will be in the next release (1.4.9).

Here's a list of all functions that have $uid_link:

There is only one variable that have the GET parameter "uid":

If your theme overrides one of these functions or variables in its theme.php, you need to look for lines that have $uid_link or "uid" and add those lines appropriately to your theme.  You can get the new sample/theme.php from the SVN 'stable' branch or 1.4.9 when it is released or go into your current include/themes.inc.php and look for the appropriate lines.  Do *not* modify include/themes.inc.php - just look for $uid_link and "uid" and make the analogous modifications to themes/yourtheme/theme.php.

Looking at the current "oranje" theme and the "hardwired" theme, they both appear fine to me regarding the "last uploaded by" meta album.  So I'm guessing the bug report here and on the other thread (for hardwired) are based on non-original themes, with further customizations.  Please check the functions and variable above and make the appropriate modifications to your theme.php.