forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Bacchus on January 13, 2006, 09:24:39 pm

Title: Error in the theme upgrade guide
Post by: Bacchus on January 13, 2006, 09:24:39 pm

On the theme upgrade guide, we need to correcte the number 9 to include the need for the HOME link.

http://coppermine-gallery.net/demo/cpg14x/docs/theme/edit_theme.html

We should read something similar to this instead:

Code: [Select]

// HTML template for main menu
$template_sys_menu = <<<EOT
                <span class="topmenu">
<!-- BEGIN home -->
                      <a href="{HOME_TGT}" title="{HOME_TITLE}">{HOME_LNK}</a><br /><br />
<!-- END home -->

<!-- BEGIN my_gallery -->
                        <a href="{MY_GAL_TGT}" title="{MY_GAL_TITLE}">{MY_GAL_LNK}</a><br /><br />
<!-- END my_gallery -->

<!-- BEGIN allow_memberlist -->
                        <a href="{MEMBERLIST_TGT}" title="{MEMBERLIST_TITLE}">{MEMBERLIST_LNK}</a><br /><br />
<!-- END allow_memberlist -->

<!-- BEGIN my_profile -->
                        <a href="{MY_PROF_TGT}">{MY_PROF_LNK}</a><br /><br />
<!-- END my_profile -->
etc...

That's why I did not include them in my previous upgraded themes, I just did not know about it.

Thanks!

Title: Re: [BUG] in the theme upgrade guide
Post by: Tranz on January 14, 2006, 03:50:51 am

Thank you for pointing out the omission. However, you might want to find out the meaning of "bug" and not use it when it does not apply.

Title: Re: [BUG] in the theme upgrade guide
Post by: Bacchus on January 14, 2006, 05:15:01 am

Well, it's a matter of language  ;D

But I should have said error/mistake instead of bug.

Thanks.

Title: Re: Error in the theme upgrade guide
Post by: Joachim Müller on January 25, 2006, 08:47:22 am

donnovan, could you look into this please?

Title: Re: Error in the theme upgrade guide
Post by: Joachim Müller on February 20, 2006, 08:36:01 am

*bump*

Title: Re: Error in the theme upgrade guide
Post by: Paver on February 22, 2006, 05:16:52 pm

Since the purported example from "Hardwired" in edit_theme.html doesn't match the actual "Hardwired" theme code, I thought it was fairly straight-forward to make this fix.  I made the two match now, as suggested by Bacchus, and I committed this fix to stable & devel.