forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: ulikoeln on August 31, 2005, 09:37:08 pm

Title: Useless (?) count query in all views
Post by: ulikoeln on August 31, 2005, 09:37:08 pm
While browsing the 1.4 gallery anonymously with debugging on, I found that every view
(album, thumbnail, image display ... etc) triggers a count of non-approved images.
This is probably unnecessary ...

From Debug:
[2] => SELECT /*   functions.inc 1415 */ COUNT(*) FROM cpg14b_pictures WHERE approved = 'NO'


BTW attached is a modified functions.inc that has Line numbers in the SQL statements for debugging purposes;
unfortunately not all SELECTs are capitalized in the source, so this can not be added automatically in all scripts ...

 ( functions.inc is  based on
$Revision: 1.186 $
  $Author: nibbler999 $
  $Date: 2005/05/07 10:57:46 $
)

Title: Re: Useless (?) count query in all views
Post by: Nibbler on August 31, 2005, 10:03:55 pm
I committed this tweak into themes.inc.php v1.5. Apparently it was subsequently lost by a careless commit of v1.7.