forum.coppermine-gallery.net

Support => cpg1.3.x Support => Older/other versions => cpg1.3 Miscellaneous => Topic started by: linuxhata on July 26, 2005, 06:19:01 am

Title: After adding custom header, some JS functions stops working.
Post by: linuxhata on July 26, 2005, 06:19:01 am

I've added a counter to the template.html, after that, in the gallery, clicking on image doesn't opens it in new window. I've tried to move counter to the different places of template, but still doesn't works.

here you can see it:

http://www.hangebi.com/uzrdeli [edit GauGau]Link contains mild nudity, not worksafe[/edit]

Any ideas?

Title: Re: After adding custom header, some JS functions stops working.
Post by: Joachim Müller on July 26, 2005, 07:41:44 am

then the other script uses the same function names as coppermine's config script. Either adjust one of them to use different names (if you know enough JavaScript), or use another counter.

Title: Re: After adding custom header, some JS functions stops working.
Post by: linuxhata on July 26, 2005, 08:00:19 am

<!-- TOP.HOST.GE COUNTER CODE -->
<script language=JavaScript src="http://top.host.ge/cgi-bin/cod?100+1789"></script>
<noscript>
<a target=_top href="http://top.host.ge/cgi-bin/showtop?1789">
<img src="http://top.host.ge/cgi-bin/count?ID:1789+JS:false" border=0 alt="TOP.HOST.GE"></a>
</noscript>   
<!-- / END OF COUNTER CODE --></p>

I think that there may be some error in code? (don't know HTML so good)

The problem is that I can't remove this counter, because it is counter for top-100 sites, and most visitors came from there.

Title: Re: After adding custom header, some JS functions stops working.
Post by: Joachim Müller on July 26, 2005, 08:12:25 am

the code you posted is just the command to make the page load the actual JavaScript, so you can't see anything from those lines. I already had a look at them, but as you can't mess with the code from the counter, you'll have to mess with coppermine's file script.js (if you know your way around). If you can't, then either live with the current situation or hire someone to fix this for you. There are often issues when using two different JavaScript codes. After all, JS sucks. As a workaround, I recommend changing the code that actually opens the full-size pop-up: edit displayimage.php, find

Code: [Select]

            $pic_html = "<a href=\"javascript:;\" onClick=\"MM_openBrWindow('displayimage.php?pid=$pid&fullsize=1','" . uniqid(rand()) . "','scrollbars=yes,toolbar=yes,status=yes,resizable=yes,width=$winsizeX,height=$winsizeY')\">";and replace with

Code: [Select]

            $pic_html = "<a href=\"displayimage.php?pid=$pid&fullsize=1\" target="$pid">";Not as pretty, but should do the trick.

Title: Re: After adding custom header, some JS functions stops working.
Post by: linuxhata on July 26, 2005, 09:04:09 am

Thanks for reply, I've modified it as you've said but:

Parse error: parse error, unexpected T_VARIABLE in /home/janigs/public_html/uzrdeli/displayimage.php on line 188

I'm getting this

Title: Re: After adding custom header, some JS functions stops working.
Post by: kegobeer on July 26, 2005, 12:50:08 pm

Code: [Select]

            $pic_html = "<a href=\"displayimage.php?pid=$pid&fullsize=1\" target=\"$pid\">";
Try that.

Title: Re: After adding custom header, some JS functions stops working.
Post by: linuxhata on July 27, 2005, 11:37:19 pm

That worked, thank you!