forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Owdy on March 13, 2005, 08:01:36 pm

Title: Comment notification emails
Post by: Owdy on March 13, 2005, 08:01:36 pm

I dont want emails about my own comments. It doesnt make sense  :)

Title: Re: Comment notification emails
Post by: Joachim Müller on March 14, 2005, 07:17:02 am

You're right - this doesn't make sense. There has to be an additional check in the comment notification routine. I consider this a bug, not a feature request, so I moved this accordingly (from "feature requests" to "bugs").

Joachim

Title: Re: Comment notification emails
Post by: Nibbler on March 14, 2005, 03:21:38 pm

This is harder than it looks btw.

Title: Re: Comment notification emails
Post by: nol33t on March 14, 2005, 04:37:08 pm

this problem doesn't apply for the admin only, i mean adding a check for USER_IS_ADMIN wouldn't be enough?

db_input.php

Code: [Select]

// Registered users, we can use Location to redirect
            $insert = cpg_db_query("INSERT INTO {$CONFIG['TABLE_COMMENTS']} (pid, msg_author, msg_body, msg_date, author_md5_id, author_id, msg_raw_ip, msg_hdr_ip) VALUES ('$pid', '" . addslashes(USER_NAME) . "', '$msg_body', NOW(), '', '" . USER_ID . "', '$raw_ip', '$hdr_ip')");
            $redirect = "displayimage.php?pos=" . (- $pid);
            if ($CONFIG['email_comment_notification']&& !USER_IS_ADMIN ) {

etc..

-matt-

Title: Re: Comment notification emails
Post by: Nibbler on March 14, 2005, 04:53:23 pm

You have to allow for multiple admins, so all admins need to get the notification other than the admin who posted the comment.

Title: Re: Comment notification emails
Post by: nol33t on March 14, 2005, 04:55:57 pm

harder than it looks then ;)

--edit: depends the way you see the use of comment notification actually..if it's a way to check each comments content, i guess admins can trust each others..

Title: Re: Comment notification emails
Post by: Joachim Müller on March 14, 2005, 08:28:37 pm

yes, I agree with nol33t: let's not make this too complicated and just add the simple check if a user is admin and that's it. Imo 95% of all coppermine installs do only have one admin user anyway.

Joachim

Title: Re: Comment notification emails
Post by: Joachim Müller on April 03, 2005, 02:00:14 pm

*bump*: any dev care to assign this to himself/herself?

Joachim

Title: Re: Comment notification emails
Post by: Joachim Müller on April 10, 2005, 10:49:42 am

comitted Matt's fix to devel branch. Marking as "fixed".

Joachim