forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Tranz on March 09, 2005, 01:42:50 am

Title: IP address showing in Last Viewed meta album
Post by: Tranz on March 09, 2005, 01:42:50 am
Was it intentional to show the IP address of the latest visitors in the Last Viewed meta album?

I can understand if it's displayed for an admin but I don't think it should be displayed to regular users. I think it would also bring up support requests and privacy complaints.
Title: Re: IP address showing in Last Viewed meta album
Post by: donnoman on March 09, 2005, 04:18:49 am
probably wasn't intentional.

1.32 Just shows date/time.

It seems to make sense to me to make that admin only.  I don't see a lot of value for other folks to see that.

I'll take a look at making that happen.
Title: Re: IP address showing in Last Viewed meta album
Post by: donnoman on March 09, 2005, 04:56:20 am
I caught a second problem with thumbnail captions in the last comment block; the body wasn't being bb_decoded and was being shown raw.

I was hesitant to just bb_decode comments on thumbnails in the caption since these are user contributed items and could be malicious. I didn't want them to be displayed without the report to admin function being readily available. So I run it through a strip_tags after bb_decode to hamstring any fancy stuff and hrefs.

This means just text will display on the thumbnails. It will be fully bb_decoded the other places it's displayed.

IP address display is now dependent on being in "Gallery_Admin_Mode".

fixes comitted.
Title: Re: IP address showing in Last Viewed meta album
Post by: Tranz on March 09, 2005, 10:21:45 pm
Thanks, donnoman. :)