forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Joachim Müller on February 18, 2005, 09:05:16 am

Title: HTML-Errors in keyword_select.php
Post by: Joachim Müller on February 18, 2005, 09:05:16 am
Andi (http://forum.coppermine-gallery.net/index.php?action=profile;u=898) posted this in another thread (http://forum.coppermine-gallery.net/index.php?topic=14639.0) - I separated it for better trackability:
Few HTML-Errors in this file:
  $Source: /cvsroot/coppermine/devel/keyword_select.php,v $
  $Revision: 1.5 $
  $Author: gaugau $
  $Date: 2004/12/30 06:59:00 $

- missing </head> end-Tag
- missing <body></body> Tag (start and end)
- missing doctype declaration
-Form and Table Tags are not closed in this else-part:
Code: [Select]
} else {
    echo "<b><font color='red'><b>Sorry, No keywords available !</b></font> ";
- Missing end-quote in this link: <a href='keyword_create_dict.php'>Regenerate Dictionary</a>
Hmm, and hole file is not multilingual... ;)

This needs fixing before the language files go out, someone please self-assign and fix.

Joachim
Title: Re: HTML-Errors in keyword_select.php
Post by: Joachim Müller on February 18, 2005, 03:43:43 pm
assigning this to myself, will commit asap.

Joachim
Title: Re: HTML-Errors in keyword_select.php
Post by: Joachim Müller on February 19, 2005, 07:40:02 am
committed to cvs. Please confirm fix.

Joachim
Title: Re: HTML-Errors in keyword_select.php
Post by: Andi on February 19, 2005, 02:01:12 pm
uups:
Quote
Parse error: parse error, unexpected T_STRING in D:\Localhost\dev-Coppermine\devel\keyword_select.php on line 95
  $Source: /cvsroot/coppermine/devel/keyword_select.php,v $
  $Revision: 1.6 $
  $Author: gaugau $
  $Date: 2005/02/19 06:39:16 $

EDIT:
And one additional error:
Quote
Notice: Undefined index: keywordId in D:\Localhost\dev-Coppermine\devel\keyword_select.php on line 43

changes see in attached file  ;)
Title: Re: HTML-Errors in keyword_select.php
Post by: Joachim Müller on February 21, 2005, 07:49:38 am
committed your changes as suggested. Please confirm.

Joachim
Title: Re: HTML-Errors in keyword_select.php
Post by: Andi on February 21, 2005, 04:01:37 pm
Ok, now it's perfect ;)