forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Tranz on February 16, 2005, 02:27:06 am

Title: & in URL changing to & when logging in
Post by: Tranz on February 16, 2005, 02:27:06 am
Let's say I'm viewing an image in an album and decide to log in.

I get redirected to a URL where the & was changed to & and so the link is invalid and get the following message:
Quote
The selected album/file does not exist !

If I edit the & in the URL, it will work.

Just ran a CVS update today.
Title: Re: & in URL changing to & when logging in
Post by: nol33t on February 23, 2005, 04:44:01 am
That bug was starting to tickle me on my dev gallery, so in case nobody had the time to fix it yet ( checked at the CVS, don't look like ):

in login.php,

before to call
Code: [Select]
pageheader($lang_login_php['login'], "<META http-equiv=\"refresh\" content=\"3;url=$referer\">");

$referer has to have "&amp;" replaced by "&"

the nice way is to add before
Code: [Select]
$referer=html_entity_decode($referer);
however that function is for php >= 4.3

an every php version working fix is to add before the line
Code: [Select]
$referer=preg_replace("'&amp;'","&",$referer);

hope that helps
-matt-
Title: Re: & in URL changing to &amp; when logging in
Post by: Joachim Müller on February 23, 2005, 06:09:42 am
committed fix as suggested, please confirm.

Joachim
Title: Re: & in URL changing to &amp; when logging in
Post by: Tranz on February 23, 2005, 07:33:44 am
Thanks, it worked in IE, FF, Opera.