forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Casper on February 14, 2005, 10:27:15 am

Title: empty user albums invisible to admin (same as fixed 1.2x bug)
Post by: Casper on February 14, 2005, 10:27:15 am

This has crept back in somehow.  If a user album is empty, and the user has no other albums, or only empty albums, then admin cannot see this users sub-cat or albums.  The same workaround used for the 1.2x bug does work.

In these screenshots, another user has an empty album, which the logged in user (admin) cannot see.

Title: Re: empty user albums invisible to admin (same as fixed 1.2x bug)
Post by: Joachim Müller on February 14, 2005, 05:05:25 pm

Casper,

could you apply the cpg1.2-fix then? Thanks in advance.

Joachim

Title: Re: empty user albums invisible to admin (same as fixed 1.2x bug)
Post by: Casper on February 14, 2005, 05:42:01 pm

Joachim,

sorry, I know the workaroud to delete these albums, but not the fix to make them show.

it is not the actual albums that don't show, they do if you manually type the url, it is the category.  If the cat 10002 has no pics in it, then the cat is not shown in the user galleries.

Hope that is clear.

Title: Re: empty user albums invisible to admin (same as fixed 1.2x bug)
Post by: Nibbler on February 14, 2005, 06:25:31 pm

The issue is with the query in list_users_query() in udb_base.php. It needs a pic to be in the album for the gallery icon feature to function, if there is no pic in the album then the join gives you no results.

Title: Re: empty user albums invisible to admin (same as fixed 1.2x bug)
Post by: omniscientdeveloper on February 14, 2005, 06:50:07 pm

Ok. I'll fix this one also. I have to reinstall my dev version, so it'll be tomorrow evening before I can commit it.

....Changing it to a left join should fix it.

Title: Re: empty user albums invisible to admin (same as fixed 1.2x bug)
Post by: omniscientdeveloper on February 18, 2005, 01:38:02 am

I just noticed that I accidently committed this "left join" change, before I tested it. Can someone verify that it works. I won't be able to test it (fix if broken) for a couple hours.

Fixed. Please verify that it's giving the expected behaviour. Once it's verified, I'll remove the old code and recommit.

Title: Re: empty user albums invisible to admin (same as fixed 1.2x bug)
Post by: Joachim Müller on February 24, 2005, 10:15:41 am

Casper, can you confirm Omni's fix?

Joachim

Title: Re: empty user albums invisible to admin (same as fixed 1.2x bug)
Post by: Casper on February 24, 2005, 05:18:33 pm

Yes, it now works as expected.

Thread marked as fixed.