forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: musikalg on February 06, 2005, 02:24:36 am

Title: Keywords from images in private albums visible
Post by: musikalg on February 06, 2005, 02:24:36 am

I have enabled clickable keywords in search. If I use the seach function without logging in I can  still see keywords from pictures in private albums. If I click on them I just get "No image to display".

Title: Re: Keywords from images in private albums visible
Post by: Joachim Müller on February 24, 2005, 10:30:31 am

assigning this issue to me.

Title: Re: Keywords from images in private albums visible
Post by: Joachim Müller on March 01, 2005, 07:45:33 am

this is what I have come up with, although I don't think it is correct (notice the silly "WHERE" statement) - please review.
In include/keyword.in.php, I changed

Code: [Select]

$result = mysql_query("select keywords from {$CONFIG['TABLE_PICTURES']}");to

Code: [Select]

$result = mysql_query("select keywords FROM {$CONFIG['TABLE_PICTURES']} WHERE 1=1 $ALBUM_SET");It does what it is suppossed to do, but it doesn't look very elegant.

Joachim

Title: Re: Keywords from images in private albums visible
Post by: Tranz on March 01, 2005, 08:25:19 am

It seems to work.

Title: Re: Keywords from images in private albums visible
Post by: nol33t on March 01, 2005, 08:29:17 am

Quote

it doesn't look very elegant

i think it does ;)
didn't check the rest of the code but imho that's how album_set / forbidden_set etc.. should also be called/used, it's not silly at all

Title: Re: Keywords from images in private albums visible
Post by: Joachim Müller on March 01, 2005, 10:01:47 am

OK, so I'm marking this as "fixed" then.

Joachim