forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Andi on December 24, 2004, 01:23:14 am

Title: small php-syntax errors
Post by: Andi on December 24, 2004, 01:23:14 am

Hi :)

in
searchnew.php,v 1.39 2004/12/12 10:24:05 gaugau
and
picmgr.php,v 1.11 2004/12/19 03:43:07 nibbler999

are some small syntax-errors like this sample:

Code: [Select]

$listArray[$list_count][cat] = $lang_search_new_php['albums_no_category'];
$listArray[$list_count][aid] = $row['aid'];
$listArray[$list_count][title] = $row['title'];
correct is:

Code: [Select]

$listArray[$list_count]['cat'] = $lang_search_new_php['personal_albums'];
$listArray[$list_count]['aid'] = $row['aid'];
$listArray[$list_count]['title'] = $row['title'];

EDIT:

and this:

Code: [Select]

        foreach ($listArray as $val) {
            if ($val[cat] != $alb_cat) {
          if ($alb_cat) $select .= "</optgroup>\n";
                $select .= '<optgroup label="' . $val[cat] . '">' . "\n";
                $alb_cat = $val[cat];
            }
            $select .= '<option value="' . $val[aid] . '"' . ($val[aid] == $sel_album ? ' selected' : '') . '>   ' . $val[title] . "</option>\n";

::: $val['cat'] / $val['aid']  /  $val['title']

Title: Re: small php-syntax errors
Post by: Joachim Müller on December 28, 2004, 06:48:28 am

fixed in searchnew.php v1.41 and picmgr.php v1.12. As usual: well spotted, thanks for your hard work squashing those bugs :D.

Joachim

Title: Re: small php-syntax errors
Post by: Tranz on December 28, 2004, 07:07:46 am

Seriously... I'm in awe of Andi's meticulousness. :) (https://forum.coppermine-gallery.net/proxy.php?request=http%3A%2F%2Ftu2.net%2Fforums%2Fimages%2Fsmiles%2Ficon_thumbs_up.gif&hash=c577483a9e561407c273604320459d4fbbe4c4da)

Title: Re: small php-syntax errors
Post by: Joachim Müller on December 28, 2004, 07:18:21 am

@Thu: hehe, had to look this word up ;)
@Andi: meticulousness (http://www.dict.cc/?s=meticulousness&l=d) means "Akribie", "(peinliche) Genauigkeit"

 ;D GauGau

Title: Re: small php-syntax errors
Post by: Tranz on December 28, 2004, 07:37:20 am

I struggled to find just the right word to describe Andi's amazing ability so that was what came to mind. :)

Title: Re: small php-syntax errors
Post by: Tarique Sani on December 28, 2004, 07:43:53 am

Yes, Andi is indeed being really meticulous - Thanks Andi

Title: Re: small php-syntax errors
Post by: Andi on January 22, 2005, 07:28:42 pm

Quote

@Andi: meticulousness means "Akribie", "(peinliche) Genauigkeit"

hehe :)

thx for this translation, i don't know this word  ::)
You know, my english is very bad....

But it's true, in this point i'm very meticulous.
That comes from the Coppermine transformation to vkpMx. I must compare every lines in a file when a new version comes from CVS. And i'm coding with php-setting error_reporting(E_ALL) to see and fix all the small errors....


ps. somewhat late
Happy New Year and best whishes to the Coppermine Team