forum.coppermine-gallery.net
No Support => Feature requests => Topic started by: spade on October 30, 2004, 10:41:53 am
-
Hi,
I would love to see forward and backward wind buttons beside the film strip which would allow me to advance or rewind the filmstrip by four picture without changing the viewed image, to have another way of browsing through the pictures.
Thanks a bunch!
-
Very good idea.
-
added this feature to the todo list on the dev board.
Joachim
-
That's a big wishlist item for me too. I want to expand my gallery to hundreds of stock shots, but don't want my potential customers to think 7 or so thumbnails in the thumbstrip is all they can access at any one time. Being able to go to the next group of filmstrip thumbs, whether 15 or 28 or whatever, would be a big big feature for me as it would increase the client's scanning speed and increase my chances of sales.
-
Ideally this will need a XMLhttprequest hack which means that just the filmstrip img src are changed - the page does not reload - good idea
-
@Tarique: something like this? (http://nol33t.free.fr/devel/displayimage.php?album=1&pos=22) ;D
XML HTTP Requests are wild!, thanx for having made me discover it
note: example not workin' on IE ( at least not mine..), for some obscure M$ reason, but that is fixable. ( anyway get Firefox (http://www.getfirefox.com) :P )
-matt-
-
@nol33t: Did you do a browser check to show one script for non-IE and another for IE?
http://jibbering.com/2002/4/httprequest.html
-
did it yea: at the end of http://nol33t.free.fr/devel/scripts.js
but my IE is really weird, so maybe it is actually working...
-
I get the unknown runtime error with IE. Don't know if this will help, but in your .js file there's a blank line after xmlhttp.send(null); You can try removing it.
Not really related, but something I noticed. Instead of wrapping a href tag around your forward and backward buttons, why not just do this:
<img src="images/prev.gif" border="0" onclick="BrowseFilmstripPrev();"> You don't get a pointer finger when you hover over it, but you can add title="Click for a previous image" to display a mouseover comment.
-
I get the unknown runtime error with IE. Don't know if this will help, but in your .js file there's a blank line after xmlhttp.send(null); You can try removing it.
tried, still not workin' on mine, i'll read some more doc tomorrow to figure that out
Not really related, but something I noticed. Instead of wrapping a href tag around your forward and backward buttons, why not just do this:
<img src="images/prev.gif" border="0" onclick="BrowseFilmstripPrev();"> You don't get a pointer finger when you hover over it, but you can add title="Click for a previous image" to display a mouseover comment.
Well you noticed good, cause it's indeed nicer now...;)
-
How about changing
xmlhttp.open("GET", updateUrl);
to
xmlhttp.open("GET", updateUrl, true);
-
well doc says (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/xmlsdk/html/xmmthopenixmlhttprequest.asp) the call should be async by default, but we never know i'll give it a try tonite ;)
I've also read somewhere that it could be the content of xmlhttp.responseText which could throw the IE runtime..even if imo the one i'm outputting is pretty clean..e.g.: http://nol33t.free.fr/devel/filmstrip.php?album=1&pos=22&dir=l
-
I also read it's async by default, but all the examples I've seen always show true or false - they don't omit it.
-
@kegobeer: it's Friday nite here soon, so let's bet some beer ;D
debugging commands:
element.innerHTML; ( so content before the call ):
"<TBODY>
<TR>
<TD id=th1><A href=\"displayimage.php?album=1&pos=0\"><IMG class=image title=\"Nom du fichier : DSC00111.jpg Poids du fichier : 89KB Dimensions : 800x600 Ajouté le : 14 Fev 2005\" height=100 alt=DSC00111.jpg src=\"albums/userpics/10001/thumb_DSC00111.jpg\" border=0></A> </TD>
<TD id=th2><A href=\"displayimage.php?album=1&pos=1\"><IMG class=image title=\"Nom du fichier : DSC00284.jpg Poids du fichier : 110KB Dimensions : 800x600 Ajouté le : 17 Fev 2005\" height=100 alt=DSC00284.jpg src=\"albums/userpics/10001/thumb_DSC00284.jpg\" border=0></A> </TD>
<TD id=th3><A href=\"displayimage.php?album=1&pos=2\"><IMG class=image title=\"Nom du fichier : DSC00294.jpg Poids du fichier : 101KB Dimensions : 800x600 Ajouté le : 17 Fev 2005\" height=100 alt=DSC00294.jpg src=\"albums/userpics/10001/thumb_DSC00294.jpg\" border=0></A> </TD>
<TD id=th4><A href=\"displayimage.php?album=1&pos=3\"><IMG class=image title=\"Nom du fichier : DSC00296.jpg Poids du fichier : 100KB Dimensions : 800x600 Ajouté le : 17 Fev 2005\" height=100 alt=DSC00296.jpg src=\"albums/userpics/10001/thumb_DSC00296.jpg\" border=0></A> </TD>
<TD id=th5><A href=\"displayimage.php?album=1&pos=4\"><IMG class=image title=\"Nom du fichier : DSC00322.jpg Poids du fichier : 99KB Dimensions : 800x600 Ajouté le : 17 Fev 2005\" height=100 alt=DSC00322.jpg src=\"albums/userpics/10001/thumb_DSC00322.jpg\" border=0></A> </TD></TR></TBODY>"
xmlhttp.responseText; ( ..after the call )
"<td><a href=\"displayimage.php?album=1&pos=1\"><img src=\"albums/userpics/10001/thumb_DSC00284.jpg\" class=\"image\" height=\"100\" border=\"0\" alt=\"DSC00284.jpg\" title=\"Nom du fichier : DSC00284.jpg
Poids du fichier : 110KB
Dimensions : 800x600
Ajouté le : 17 Fev 2005\" /></a> </td>
<td><a href=\"displayimage.php?album=1&pos=2\"><img src=\"albums/userpics/10001/thumb_DSC00294.jpg\" class=\"image\" height=\"100\" border=\"0\" alt=\"DSC00294.jpg\" title=\"Nom du fichier : DSC00294.jpg
Poids du fichier : 101KB
Dimensions : 800x600
Ajouté le : 17 Fev 2005\" /></a> </td>
<td><a href=\"displayimage.php?album=1&pos=3\"><img src=\"albums/userpics/10001/thumb_DSC00296.jpg\" class=\"image\" height=\"100\" border=\"0\" alt=\"DSC00296.jpg\" title=\"Nom du fichier : DSC00296.jpg
Poids du fichier : 100KB
Dimensions : 800x600
Ajouté le : 17 Fev 2005\" /></a> </td>
<td><a href=\"displayimage.php?album=1&pos=4\"><img src=\"albums/userpics/10001/thumb_DSC00322.jpg\" class=\"image\" height=\"100\" border=\"0\" alt=\"DSC00322.jpg\" title=\"Nom du fichier : DSC00322.jpg
Poids du fichier : 99KB
Dimensions : 800x600
Ajouté le : 17 Fev 2005\" /></a> </td>
<td><a href=\"displayimage.php?album=1&pos=5\"><img src=\"albums/userpics/10001/thumb_DSC00390.jpg\" class=\"image\" height=\"100\" border=\"0\" alt=\"DSC00390.jpg\" title=\"Nom du fichier : DSC00390.jpg
Poids du fichier : 82KB
Dimensions : 800x600
Ajouté le : 17 Fev 2005\" /></a> </td>
"
so maybe my output is not that clean after all...(at least not clean enough for IE ::))
-
Ohhh I'm very Happy to see this future ... but why not only the filmstrip not to reload ?!!
It's possible to change the intermediate pic without reloading the page. By this example ...
<script language="javascript" type="text/javascript">
img1 = "pic1.jpg";
img2 = "pic2.jpg";
img3 = "pic3.jpg";
function displayText(id,text){
document.getElementById(id).innerHTML = eval(text);
}
</script>
and on click ...
<a href="javascript:displayText('intermediate', 'img1');">Your Thumb in Filmstrip</a>
<a href="javascript:displayText('intermediate', 'img2');">Your Thumb in Filmstrip</a>
<a href="javascript:displayText('intermediate', 'img3');">Your Thumb in Filmstrip</a>
<div id="intermediate">
pic loaded
</div>
It's possible to do this differently with DOM ...
-
@Rodinou: funny, thought about it this afternoon
@kegobber: guess what, no innerHTML for the table object with IE...(http://www.insidedhtml.com/forums/viewConverse.asp?d_id=14448&start=3)
nevermind, i'll figure out a workaround ( and it would be cool if it could be with one xmlhttp call only, want to avoid updating 'thumb_cell's one by one )
-matt-
-
ok that was quick: ;D
added a <span id='filmstrip'> </span> around the table, and that's the one i'm refreshing: works for me now, i you wanna try it out:
http://nol33t.free.fr/devel/displayimage.php?album=1&pos=22
(still a little bug/glitch when you're at the end of the filmstrip though)
--edit: @DevTeam: if you're interrested i can try to package it as a "clean" contrib
-
Hey, that's really cool. I've been working on something similar but I don't know how to make it so only the filmstrip updated. My buttons are also at the top instead of by the filmstrip. However, what I have is fastforward x number based on the number of filmstrip items set in config. I think a combination of what we have would be good. So use what you have and make the filmstrip move x photos instead of one at a time.
Here (http://cpg.thu.lunarpages.com/displayimage.php?album=7&pos=0#top_fileviewer)'s what I have so far.
-
So use what you have and make the filmstrip move x photos instead of one at a time.
you mean adding just like you did but on the filmstrip level, two extra arrows, to forward/reward by 'x' thumbs at a time? ( i like the one-by-one motion..:) )
My buttons are also at the top instead of by the filmstrip
actually the top buttons could be use to change the intermediate pic the same way ( without reloading the whole page, and it would trigger the move of the filmstrip accordingly ), even if i'm going a tiny bit of topic ;)
I don't know how to make it so only the filmstrip (matt:you meant intemediate pic no?) updated
i can send you a quick explanation in a couple of steps if you want
-matt-
-
Mmmmmmmm ... Nol33t ... you have maybe a dhtml solution of our flash idea !!! :)
Creating a filmstrip with 15 thumbs per 15 thumbs
Loading the intermediate pic by DOM system or this I have put ...
Is it possible ...
@ Nol33t : please, install MSN, one day :) I'm fed up flooding this forum with your talent !
-
So use what you have and make the filmstrip move x photos instead of one at a time.
you mean adding just like you did but on the filmstrip level, two extra arrows, to forward/reward by 'x' thumbs at a time? ( i like the one-by-one motion..:) )
Sure, we can do both one by one and group by group. Some albums may benefit more from one or the other.
actually the top buttons could be use to change the intermediate pic the same way ( without reloading the whole page, and it would trigger the move of the filmstrip accordingly ), even if i'm going a tiny bit of topic ;)
Would that make things go faster? Save bandwidth? I guess it would make a difference for dialup users.
I don't know how to make it so only the filmstrip (matt:you meant intemediate pic no?) updated
I meant the filmstrip, the way you did it. So the ideal way was to fastforward the filmstrip without having to change the intermediate pic.
i can send you a quick explanation in a couple of steps if you want
Sure, that would be great. Thanks. If it goes into the cvs version we'll let you know so we can give you credit under whatever name you want. We just need approval from the other team members.
-
Quote from: nol33t on Yesterday at 05:07:55 PM
actually the top buttons could be use to change the intermediate pic the same way ( without reloading the whole page, and it would trigger the move of the filmstrip accordingly ), even if i'm going a tiny bit of topic
Would that make things go faster? Save bandwidth? I guess it would make a difference for dialup users.
Exactly.
In fact, Dev Team sees often Coppermine is not very "loud" for a server. I don't know how many visitors you do ... but for my part, I realize about 4000 visits/day with 100 000 view pages / day !!!
When loading a whole page, you access EACH TIME to DB ... with this system, you
- save bandwidth : nomore page is created
- save requests server : in fact dhtml calls only pics, and not all ...
You say me "but how the visitors can have the url of the pic"
With DOM, all is possible to change on the fly ... :) Of course, 100% Compatible Opera / IE / and Gecko
But Nolt ... instead of making a filmstrip, we could be able to realize a similar system Flash ...
I have put on this site (use search engine) how to create CROP thumbs with CSS with actual rect. thumbs ...
-
@ nol33t and TranzNDance:
Great work guys, this is close to exactly what I've been hoping for: my ideal is to advance the filmstrip only. Then my clients can click on the one they want to look at or keep going, without the time overhead waiting for the intermediate to open. Very cool, I gotta have this!
@ nol33t
Will you be continuing your work in the other thread with the big, scrollable thumbnail field too, or going more in this direction? Both are tempting...For my needs, it would be really bitchin to combine the movable filmstrip the way it in this thread, but be able to jump perhaps a group of 20 thumbs at a time, the way you have it in the other thread.
Thanks for the great work guys, really exciting.
-
Will there be compatibility issues with using this? server or browser-wise? Sorry, I'm dumb about DOM. :D
-
you mean adding just like you did but on the filmstrip level, two extra arrows, to forward/reward by 'x' thumbs at a time? ( i like the one-by-one motion..:) )
Sure, we can do both one by one and group by group. Some albums may benefit more from one or the other.
done! (http://nol33t.free.fr/devel/displayimage.php?album=1&pos=22), tell me what you think :D
that was a nice suggestion, cause it made me recoded the whole thing in a lot more nicer way ;)
- about compatibility issues: none server side, and on the client side, with not xmlhttp compliant and / or not javascript enabled browsers, the arrows won't work, but i think that's it ( i mean it won't corrupt the display nor make the browser crash )
- about saving bandwidth, since you just reload 1 or "x" thumbs but not the entire page, scrolling with the filmstrip definitely save some.
- i got an issue to fix ( meta albums..), and code/explanations should be here soon, files modified being:
. scripts.js
. theme.php of the theme used ( and themes.inc.php to make it work with the core version )
. filmstrip.php, a new file, which returns the filmstrip depending of the album and "the position" you want to make the filmstrip move: respect the privacy pictures settings
For what is about changing the same way the intermediate pic but with the top buttons, actually it may be more complicated, because of the rest of the content..comments and votes would be desynchronised, so you would have to update them too, etc..
[ot]
Will you be continuing your work in the other thread with the big, scrollable thumbnail field too, or going more in this direction?
look at what's written under my nickname & avatar..;) flash remoting is a whole different thing, but that i will continue for sure
[/ot]
-matt-
-
That's great. 8)
The navigation in the img bar is unnecessary. I only put it there because it was easier. ;) Having what you have is fine, IMO.
Some things to build upon what you have. When I tried this myself, I got feedback to indicate the number of items that will be going forward or backward, in the tooltip. Another thing is to internationalize the text. Another is to disable the forward navigation when at the end of the album. I have the code for all that. You can either use what I have or once you volunteer your code, we could try to integrate them.
Here's an excerpt of what I have in themes.inc.php for theme_html_img_nav_menu().
$max_items = $CONFIG['max_film_strip_items'];
$end = $pic_count - 1;
$end_tgt = "{$_SERVER['PHP_SELF']}?album=$album$cat_link&pos=$end#top_fileviewer";
$end_title = $lang_img_nav_bar['go_album_end'];
$meta_nav .= "<link rel=\"end\" href=\"$end_tgt\" title=\"$end_title\" />
";
if ($pos == 0) {
$start_tgt = "javascript:;";
$start_title = "";
$meta_nav .= "<link rel=\"start\" href=\"$start_tgt\" title=\"$start_title\" />
";
}
if ($pos > 0) {
$start = 0;
$start_tgt = "{$_SERVER['PHP_SELF']}?album=$album$cat_link&pos=$start#top_fileviewer";
$start_title = $lang_img_nav_bar['go_album_start'];
$prev = $pos - 1;
$prev_tgt = "{$_SERVER['PHP_SELF']}?album=$album$cat_link&pos=$prev#top_fileviewer";
$prev_title = $lang_img_nav_bar['prev_title'];
$meta_nav .= "<link rel=\"prev\" href=\"$prev_tgt\" title=\"$prev_title\" />
";
$meta_nav .= "<link rel=\"start\" href=\"$start_tgt\" title=\"$start_title\" />
";
if ($pos >= $CONFIG['max_film_strip_items']) {
$rewind = $pos - $max_items;
$rew_tgt = "{$_SERVER['PHP_SELF']}?album=$album$cat_link&pos=$rewind#top_fileviewer";
$rew_title = sprintf($lang_img_nav_bar['go_back_x_items'], $max_items);
} else {
$rew_tgt = $start_tgt;
$rew_title = $start_title;
}
} else {
$prev_tgt = "javascript:;";
$prev_title = "";
$rew_tgt = "javascript:;";
$rew_title = "";
}
if ($pos < ($pic_count -1)) {
$next = $pos + 1;
$next_tgt = "{$_SERVER['PHP_SELF']}?album=$album$cat_link&pos=$next#top_fileviewer";
$next_title = $lang_img_nav_bar['next_title'];
$meta_nav .= "<link rel=\"next\" href=\"$next_tgt\" title=\"$next_title\"/>
";
if ($pos <= ($pic_count -1) - ceil(($max_items/2))) {
$fastforward = $pos + $max_items;
if ($fastforward >= $pic_count) {
$ff_tgt = $end_tgt;
$ff_title = $end_title;
} else {
$ff_tgt = "{$_SERVER['PHP_SELF']}?album=$album$cat_link&pos=$fastforward#top_fileviewer";
$ff_title = sprintf($lang_img_nav_bar['go_forward_x_items'], $max_items);
}
} else {
$ff_tgt = "javascript:;";
$ff_title = "";
}
} else {
$next_tgt = "javascript:;";
$next_title = "";
$ff_tgt = "javascript:;";
$ff_title = "";
}
For the text internationalization in english.php:
$lang_img_nav_bar = array(
[snipped for clarity]
'go_album_end' => 'Skip to end', // cpg1.4
'go_album_start' => 'Return to start', // cpg1.4
'go_back_x_items' => 'go back %s items', // cpg1.4
'go_forward_x_items' => 'go forward %s items', // cpg1.4
);
Thank you so much for your time and help on this. :)
-
it becomes very interesting !!! :)
but ... why don't see this vision to a "new" vision of coppermine ?!!
So ... let me explain ...
if someone click on an album ...
he has on the right, on the left, on the top, on the bottom ... xxxx thumbs ... with nolt33 system, a gallery can contain 10 or 6000 pics, there are no problem !!! ...
And by default, it's the first picture which appears ... with THIS system, you can "stop" the slideshow system which crashes server when 1. a lot of people who use it at same time, and creates a big very loud page when a gallery contains more than 300 pics (and for me, it's often the case)
and of course ... very simple for user ...
the ONLY THING, I don't know how this system you can "count" a viewed pic :( ...
I know you talk very often about "compatibility" ... but in 90% of the users, people has
- IE
- GECKO browser
- OPERA
OK, 10% surfes with lynx or mosaic ... but we are in 2005 ! :) right ? ...
Nolt, your "exploration" of Coppermine is simply fascinating :( ... really.
-
where can I get the coding for the wind buttons, I looked at photos (IE6) had no problem, that would be so cool if I could add it to my site.
Thanks
-
where can I get the coding for the wind buttons, I looked at photos (IE6) had no problem, that would be so cool if I could add it to my site.
Thanks
-
Ok, I have "AT LEAST" found EXACTLY the vision I had ... :)
http://dasme.org/imagegal/demo
@ TranzNDance > DOM is THIS :)
-
now that is cool, how was that made?
Ok, I have "AT LEAST" found EXACTLY the vision I had ... :)
http://dasme.org/imagegal/demo
@ TranzNDance > DOM is THIS :)
-
@ nol33t, fantastic, great job. ;D This is ideal for me for now. :D
I've got Casper's Paypal shopping hack in Eyeball on my website, do you think this will present any problems?
I'll keep checking for when you have the coding posted.
Thanks for your hard work, much appreciated.
-
so does that mean that anyone can use the coding, all my family memeber meantioned that they would like to have a button to advance and go back in th e random pix, but I do not know enough to do the coding myself, all that I ask is the premission to use the coding on my site.
Thanks
-
@jaysonyates
I'm sure when the coding is done, it will be shared.
patience
snork
-
Hopefully, we can put it into the next version. ;)
-
;D
wait a couple of more days, i'm improving it right now:
- no left or right arrows when you're at the beginning / end of the album
- internationalization
- cleaning my code, i don't want to submit a messy one ;)
-matt-
-
- no left or right arrows when you're at the beginning / end of the album
the top would be if you are of the end of the album, it loops on the first pics of the album ... because if you have to click 20 or 30 times ... but want to review the first pics ... I let you imagine :)
And of course, the same case at the beginning : on the left, see directly the last pics ...
What do you think about the link I have posted ?
-
Can't wait, that will be a totally awesome addition the coppermine.
;D
wait a couple of more days, i'm improving it right now:
- no left or right arrows when you're at the beginning / end of the album
- internationalization
- cleaning my code, i don't want to submit a messy one ;)
-matt-
-
- no left or right arrows when you're at the beginning / end of the album
the top would be if you are of the end of the album, it loops on the first pics of the album ... because if you have to click 20 or 30 times ... but want to review the first pics ... I let you imagine :)
I tried that with my own gallery... at the end of the album, the next button looped to the start of the gallery. That confused my friends who didn't realize they were seeing the same photos for a bit. It's possible to have a dedicated 'go back to start' button. I already have the start variable there (not committed as we await nol33t's mod). So cpg 1.4 will allow you to navigate with the keyboard to go next/previous/end/start. This navigation ability is included in Opera, and there is an extension for Firefox. It is handy to use for different pages of a forum, too.
-
;D
wait a couple of more days, i'm improving it right now:
Thanks Matt, looking forward to it
-
nol33t, are you coding this for 1.3 or 1.4? Or would it work with both?
edit: Your gallery is 1.4 so it looks like that's what it will work with. cool. :) And that's neat that it does a countdown of the number of pics remaining in the album.
-
nol33t, are you coding this for 1.3 or 1.4? Or would it work with both?
1.4, but a downgrade wouldn't be too difficult imo (could work without other changes on 1.3, i'll try).
and actually..here's the mod attached ;)
I added as you suggested:
- on the tooltip the number of pictures left
- arrows disappearing when you're at the start or the end of the filmstrip
- internationalization ( english.php, a new array $lang_film_strip )
last demo still here (http://nol33t.free.fr/devel/displayimage.php?album=1&pos=22)
I tried a lot of different implementations ( cause there was many different solutions to do this ), and the one i'm submitting does work with IE/Mozilla browsers, and is the most comprehensive i manage to found out ( at least for me ;) )
Basically, here is how it works:
- when the template for the filmstrip is generated, it adds in the html a comment tag <!--STARTPOSX#X'#X''#X'''ENDPOS--> where X, X', X'' and X''' will be the new "positions" if you click on one of the buttons:
- X for fast rewind ( pos - number of thumbs set up for the filmstrip in the config )
- X' for rewind ( pos -1 )
- X'' for forward ( pos +1 )
- X'' for fast forward ( pos + number of thumbs set up for the filmstrip in the config )
when you click on one of the buttons, it will call a javascript script which will parse this comment tag, and depending one which button you clicked on, send the new position to display, with the album infos, to filmstrip.php, which returns the new filmstrip. Since i use the display_film_strip() function to do that, the new filmstrip will contain the new <!--STARTPOS ENDPOS--> comment, but with the new positions ( so it loops which i kinda like :) )
the only probs i found are:
- the html code i added in $template_film_strip does not validate as XHTML 1.0, but i'm not that sure displayimage.php was before, and those are minor things to fix, and i'm must admit i'm not good at that ( which does not mean the html is real messy )
- one glitch when you're at the beginning of the filmstrip, arrow takes two clicks to dissapear, if a math geek looks at my code i'm sure he'll find the prob in 2 sec ;) )
- last but not least: you all work too fast on the devel 1.4 release, i had to merge my mod! :P ;)
If you want more explanations on my choices for this mod and its implementation, just ask
Hope you'll like it,
-matt-
-
now this will not over write my custom theme will it, nol33t?
Thanks can not wait to try it out.
-
Great job, nol33t! :) Thank you.
A couple of things ;D
- With the files from the archive, the buttons didn't work in FF, but they worked in IE. After I merged your file with my themes.inc.php, it worked. So I guess there was something missing. I diffed the two files to see what it could be but couldn't figure it out.
- I can't replicate it, but I saw this in both of our galleries. Sometimes at the end of the gallery, the message would be displayed that there was no picture to show. Sometimes that message shows and sometimes not. I would have to refresh the page to make the filmstrip return.
Thanks so much for helping out with this. (https://forum.coppermine-gallery.net/proxy.php?request=http%3A%2F%2Ftu2.net%2Femoticons%2Ficon_clap.gif&hash=2e48621c491c272735c08ccf8acb019bf9985af8)(https://forum.coppermine-gallery.net/proxy.php?request=http%3A%2F%2Ftu2.net%2Femoticons%2Ficon_thumbs_up.gif&hash=f845a31009dafd4285db67da2f3f39ffbaaab71c)
-
Sorry, I hate to ask too much since you've done so much already...
Is it possible to make it so that the script can detect that the browser has javascript enabled? And if it is not, have the tooltip say that js is required? I can see some people clicking madly away at those arrows. :D
Maybe someone else can jump in on this. :)
-
in themes.inc.php, after
{PREV_BUTTONS}
{NEXT_BUTTONS}
</td>
</tr>
you could add
<NOSCRIPT><td colspan={COLS} align="center"> Your browser doesn't support JavaScript, navigation has been disabled. </td></NOSCRIPT>
but with an internationalized error message of course ;)
--edit: a better one could be to use javascript for "printing" the buttons (with document.write() )..no javascript, no buttons..
-matt-
-
Where do all the files go? Sorry if this sounds like a stupid question, but I would hate to add the files to the wrong area, and then corrupt Coppermine.
Thanks
-
Sorry but the zip i provided is meant for 1.4, i didn't test it yet with 1.3, and in any cases if you use a custom theme you will have to manually modify the theme.php file in the folder of the theme you use.
Patience is a virtue..;)
-
--edit: a better one could be to use javascript for "printing" the buttons (with document.write() )..no javascript, no buttons..
-matt-
That would be cool indeed. :)
@jaysonyates, do you think you could wait til 1.4 comes out with this included? You would still have to manually update your custom theme, but there would be instructions to upgrade custom themes from 1.3 to 1.4.
-
That would be cool indeed. :)
ok here it is then ;)
- in theme.php replace
{PREV_BUTTONS}
{NEXT_BUTTONS}
with
<span style="visibility:hidden" id="buttons">
{PREV_BUTTONS}
{NEXT_BUTTONS}
</span>
<script language="JavaScript" type="text/javascript">
<!--
var buttons = document.getElementById("buttons");
buttons.style.visibility="visible";
//-->
</script>
and in script.js, find
filmstrip.innerHTML=xmlhttp.responseText;
and add right after
var buttons = document.getElementById("buttons");
buttons.style.visibility="visible";
I'm really no DOM expert, so chances are that there's better solutions, but it works with IE/and Mozilla browsers :)
-matt-
-
Man! That is like asking a little kid not to open his gifts before X-Mas, "sigh" oh, I can wait..........................................................................................................................................................................................................Is it here yet? ;D
--edit: a better one could be to use javascript for "printing" the buttons (with document.write() )..no javascript, no buttons..
-matt-
That would be cool indeed. :)
@jaysonyates, do you think you could wait til 1.4 comes out with this included? You would still have to manually update your custom theme, but there would be instructions to upgrade custom themes from 1.3 to 1.4.
-
Great job, nol33t! It worked in IE and FF.
I checked in Opera and the buttons didn't respond. Javascript was enabled. I turned on the setting to have the console show up if there is an error. When I clicked the button, the console showed up, with a long list of stuff so I don't know about posting it here. However, when I disabled js, the buttons didn't show up so that part worked.
Opera has great functions built-in that FF needs extensions for. But it's times like these when it is just a bane on a web dev's existence. :P
-
About Opera: the actual version ( 7.5x ) actually got problems with xmlhttp, web services like Gmail also don't work with..that's why they are rewritting this part...and i just tried with the Beta 8.0, and the buttons worked ;)
-matt-
-
<span style="visibility:hidden" id="buttons">
{PREV_BUTTONS}
{NEXT_BUTTONS}
</span>
<script language="JavaScript" type="text/javascript">
<!--
var buttons = document.getElementById("buttons");
buttons.style.visibility="visible";
//-->
</script>
Always rather display than visibility : visibility "hides" the layer, but it "keeps" the place it takes ..
Display : block / display : none ... the layer disappears totally, even if it takes several pixels
<span style="display : none" id="buttons">
{PREV_BUTTONS}
{NEXT_BUTTONS}
</span>
<script language="JavaScript" type="text/javascript">
<!--
var buttons = document.getElementById("buttons");
buttons.style.display="block";
//-->
</script>
So your code becomes interesting ... but is it possible to do a version like your flash mod but with dhtml ? (you have proved with this mod it's possible)
-
thanx for the display / visibility tip :)
is it possible to do a version like your flash mod but with dhtml ? (you have proved with this mod it's possible)
well everything is possible..but the amount of work would be imo - even though quite fun - quite big..
-
Always rather display than visibility : visibility "hides" the layer, but it "keeps" the place it takes .. Display : block / display : none ... the layer disappears totally, even if it takes several pixels <span style="display : none" id="buttons"> {PREV_BUTTONS} {NEXT_BUTTONS} </span> <script language="JavaScript" type="text/javascript"> <!-- var buttons = document.getElementById("buttons"); buttons.style.display="block"; //--> </script>
So your code becomes interesting ... but is it possible to do a version like your flash mod but with dhtml ? (you have proved with this mod it's possible)
Thanks, Rodinou. It's good to make the blank space go away if the arrows are not there. However, the arrows disappear after the first series. Here's an example (http://cpg.thu.lunarpages.com/displayimage.php?album=7&pos=0). It happens in IE and FF.
-
it also has to be in script.js, after filmstrip.innerHTML=xmlhttp.responseText; ;)
var buttons = document.getElementById("buttons");
buttons.style.display="block";
-matt-
-
Thanks, that fixed it.
-
So your code becomes interesting ... but is it possible to do a version like your flash mod but with dhtml ? (you have proved with this mod it's possible)
Let's finish this first so that we can release the next cpg version with this. ;)
-
Thanks, that fixed it.
cool, cause it's look's real nice when javascript isn't enabled now :)
Let's finish this first so that we can release the next cpg version with this. Wink
you want me to check for the " random bug" ( no image to display ) when at the end of the album?
found another little one too, if nbr of pics of the album <= items in the filmstrip, both right and left arrows have to be disabled
-
you want me to check for the " random bug" ( no image to display ) when at the end of the album?
found another little one too, if nbr of pics of the album <= items in the filmstrip, both right and left arrows have to be disabled
Do you see the random bug too or is it just me?
The second one should be straightforward checking for the $pic_count <= $max_items
-
Another thing :)
The mouse pointer doesn't appear on the arrows ...
style="pointer : hand"
resolves it. I know, it's not necessary, but I think if a user doesn't see his pointer change, he can think it's not clickable.
I like very much ...
So ...
MY request :)
If dhtml change is "too hard" ... or "too long", is it possible the filmstrip contains a "whole thumbnails" of a page ?! So ... in my case I have
20 pics per page ... so the filmstrip could contain 20 pics ?!
Thanx for this mod (for me it's more a mod : it's a great evolution of Coppermine)
-
Tranz, I got the bug at the end of the images too, couldn't get it to go back with the intermed. pic buttons either
Site looks cool, are you running 1.4?
-
Another thing :)
The mouse pointer doesn't appear on the arrows ...
style="pointer : hand"
resolves it. I know, it's not necessary, but I think if a user doesn't see his pointer change, he can think it's not clickable.
I agree that that would improve the user interface. Do you know where that goes?
-
Site looks cool, are you running 1.4?
Thank you. My main site (in my sig) runs 1.3.2. When I post examples in discussing 1.4, that would be 1.4.1.
As a user, I can't wait to run v 1.4x on my main gallery. :D
-
Not really related, but something I noticed. Instead of wrapping a href tag around your forward and backward buttons, why not just do this:
<img src="images/prev.gif" border="0" onclick="BrowseFilmstripPrev();"> You don't get a pointer finger when you hover over it, but you can add title="Click for a previous image" to display a mouseover comment.
Well you noticed good, cause it's indeed nicer now...;)
ok, if you want to add it again...:P
theme.inc.php:
$prev_buttons = <<<EOT_PREV
<img align="left" style="cursor:pointer;cursor:hand" src="images/rewind.gif" border="0" onclick="BrowseFilmstripFastPrev()" title="$fr_title">
<img align="left" style="cursor:pointer;cursor:hand" src="images/prev.gif" border="0" onclick="BrowseFilmstripPrev()" title="$r_title">
EOT_PREV;
$next_buttons = <<<EOT_NEXT
<img align="right" style="cursor:pointer;cursor:hand" src="images/fastforward.gif" border="0" onclick="BrowseFilmstripFastNext()" title="$ff_title">
<img align="right" style="cursor:pointer;cursor:hand" src="images/next.gif" border="0" onclick="BrowseFilmstripNext()" title="$f_title">
EOT_NEXT;
}
-matt-
-
Guys, at the risk of GauGau raining fire and brimstone down on my head, any guess how long it will be before 1.4 is released? I'm gathering from following the thread that this hack won't work in 1.3.2 without some custom tweaking, kind of off limits/too difficult for us noobs, yes?
Thanks Matt for the great work, it looks awesome...guess I'll have to be patient too...
....is it here yet? ::)
-
Not really related, but something I noticed. Instead of wrapping a href tag around your forward and backward buttons, why not just do this:
<img src="images/prev.gif" border="0" onclick="BrowseFilmstripPrev();"> You don't get a pointer finger when you hover over it, but you can add title="Click for a previous image" to display a mouseover comment.
Well you noticed good, cause it's indeed nicer now...;)
ok, if you want to add it again...:P
Poor matt with all these suggestions. (https://forum.coppermine-gallery.net/proxy.php?request=http%3A%2F%2Ftu2.net%2Femoticons%2Ficon_console.gif&hash=ade76d31f04c7200b4f2441a241fc9e3f96fdc5f) I'm guilty of it too. :-[ But we (https://forum.coppermine-gallery.net/proxy.php?request=http%3A%2F%2Ftu2.net%2Femoticons%2Ficon_love.gif&hash=007ca33759d6b5029c2712b7b02073de2e8db474) the work you've done on this.
-
found another little one too, if nbr of pics of the album <= items in the filmstrip, both right and left arrows have to be disabled
The second one should be straightforward checking for the $pic_count <= $max_items
themes.inc.php:
find
//padding when at the beginning of the strip
and add before
//if number of pics <= filmstrip size
if ($pic_count<=$max_items)
{
$r=-1;
$f=-1;
}
else
About the random bug, it won't stay random too much longer..;)
-matt-
just saw your post
Poor matt with all these suggestions. I'm guilty of it too. But we the work you've done on this.
no biggie, if i don't like it i'll know where to look to remove it ;)
and i'm pleased people are pleased by it ;D
-
Thanks, that fixed one thing and brought up something else...
If the filmstrip is "crowded", there is a whitespace-type element that gets pushed down, which causes extra vertical space between the thumbnail bottom and tile graphic.
You can see it from two albums. One (http://cpg.thu.lunarpages.com/displayimage.php?album=21&pos=0)is small, so the thumbnails are spaced far apart. The other one (http://cpg.thu.lunarpages.com/displayimage.php?album=20&pos=0) is below the $max_items count but is crowded. You can see the element I'm referring to when you "select all" on the page. The crowded page shows the element taking up a complete line whereas the smaller album, the element starts above the baseline of the image.
-
I see what you mean yea..but the size for your main tables are set to 600px..and not in %, so that's kinda normal no...?
--edit:( ok nothing to do with pix/% ..what i really meant is that the filmstrip has a sized set in config ( just like in 1.3.2 ) and too many thumbs in a too small table never mix well..)
if it's not ;D & you want to improve / fix that ( tried but don't manage to focus reading html tags tonight :o ),
you could try to play with $template_film_strip in theme.inc.php, specifically this part : ( it's the one i've modified )
$template_film_strip = <<<EOT
....
<!-- BEGIN thumb_cell -->
-matt-
-
You were right; changing it to % helped.
Thanks to your tip on where to look, I found the culprit, so I can go back to using px. ;D
I deleted after this:
<a href="{LINK_TGT}">{THUMB}</a>
-
awesome :), and while you were correcting it & posting i was editing my post and losing myself in theories ;D
about the  , looked at the CVS, i didn't add it, so maybe it had a use..( like adding space between thumbs to make it look like a real filmstrip..? if it's the case it would be better to play with the cellspacing of the table right above)
-
about the  , looked at the CVS, i didn't add it, so maybe it had a use..( like adding space between thumbs to make it look like a real filmstrip..? if it's the case it would be better to play with the cellspacing of the table right above)
I was wondering about its importance, too. However, I do not see any obvious drawbacks to removing it. I checked in FF, IE, and opera. The photos are still nicely spaced apart. I played with the cellspacing... it had a side-effect of adding unwanted space to the top and bottom.
I think maybe the next version of this should just use divs so we can have better control over the elements. However, this is great already. 8)
-
About the random bug, it won't stay random too much longer..;)
TranzNDance, could you please try this (worked for me):
themes.inc.php
find
//padding when at the end of the strip
else if ($pos+$start_pos > $pic_count)
and replace it with
//padding when at the end of the strip
else if ($pos +$start_pos+1> $pic_count)
filmstrip.php
find ( last line..)
echo display_film_strip($album, $cat, $pos);
and add before
$max_items = $CONFIG['max_film_strip_items'];
if ( $pos+ceil($max_items/2) > $pic_count )
{
$pos = $pic_count;
}
-matt-
-
I haven't seen that "no images to display" box, although I don't know how to replicate that bug.
Here's something else I have found, though:
1. go here (http://cpg.thu.lunarpages.com/displayimage.php?album=5&pos=9)
2. click fast rewind.
The buttons will disappear although there are more photos. The filmstrip shows 10, and there are 12 in the album.
-
ok I see that you are a real good tester, cause that one could have take time to spot! ;D
sorry about it, it's my way of checking when displaying the arrows or not, which was a little more too "relax" ... :-[
themes.inc.php:
replace
if ($pic_count<=$max_items)
{
$r=-1;
$f=-1;
}
with
if ($pic_count<=$max_items)
{
$r=-1;
$fr=-1;
$f=-1;
$ff=-1;
}
and replace
//need to display the prev buttons?
if ( $r != -1 ){
with
//need to display the prev buttons?
if ( $r != -1 || $fr != -1 ){
and same
//need to display the next buttons?
if ( $f != -1 ){
with
//need to display the next buttons?
if ( $f != -1 || $ff != -1 ){
see you for the next bug or the next feature? ;)
-matt-
-
That fixed it, thanks. (https://forum.coppermine-gallery.net/proxy.php?request=http%3A%2F%2Ftu2.net%2Femoticons%2Ficon_thumbs_up.gif&hash=f845a31009dafd4285db67da2f3f39ffbaaab71c)
It doesn't seem like we can include this into the upcoming release because there isn't enough time.
I understand that there will be disappointment.
The good news is that we are close to releasing a beta version and thus closer to using 1.4 on our sites. If we keep adding stuff, we'll never be able to release the product. :-\\
sigh, as a user, the release can't come soon enough. However, being on the dev team, it's hard to stop wanting to add things and stick to a timeline. Such a dilemma.
Until next time, this would be a great mod, though. 8)
-
@Thu: That was a pleasure working with you on that one ;)
@All: the mod is pretty easy to apply:
- some lines to add in script.js
- theme.inc.php to modify
- a new file to put at the root of your coppermine install
So when the 1.4x will be released, i'll post the modified files on this thread
-matt-
-
@Thu: That was a pleasure working with you on that one ;)
Same here. :)
So when the 1.4x will be released, i'll post the modified files on this thread
You could create a new thread once it is finalized as a mod. We can then move it over to the mods/hacks board. (We're still in feature requests now :D)
-
Actually, this should get moved anyway because there's actual code here and not just ideas.
-
is this still being developed? because I tried to implement it with 1.4.3 and am stuck... I did all the changes that I could find throughout the post and have " {PREV_BUTTONS} {NEXT_BUTTONS}" in the filmstrip instead of the actual buttons:
http://www.staticfiends.com/photos/displayimage-65-11.html
-
Actually, this should get moved anyway because there's actual code here and not just ideas.
Agreed, but the thread is cluttered and therefor hardly usable for newbies. Imo there should be a summary thread that holds the code and is being published in the mods board, while this one gets locked, with a link posted that points to the mod thread.
-
that would be very cool if one of the devs could do it, so we know it works....because when I attempted myself I must have missed something (as stated in the post above)...
-
I figured out what I was doing wrong... 8)
make sure that you take the // off of the line in themes.inc.php:
//need to display the prev buttons?
//if ( $r != -1 || $fr != -1 ){
to
//need to display the prev buttons?
if ( $r != -1 || $fr != -1 ){
this mod is too sweet...too sweet...if you want to see how I put it to use, check it out @ http://www.staticfiends.com/photos/displayimage-20-0.html
-
Hello,
Wondering about the status of this 'wind' for the flimstrip ...
Throughout reading this thread, Dev Member Thu speaks of getting this into the next release. At the time of the hack provided, the CPG version was 1.4.1, now as of this writing, the current version is 1.4.7
Also, in looking at examples of the feature in use, I visited Thu's site for inspiration and notice that she is not (no longer) using the hack. Curious, were there problems with it and it's continued adoption?
Thank you in advance.
-
When a dev team member says "next release", he/she means 1.5.
No new features will be incorporated in the 1.4.x series. Only bug fixes.
-
thank you for the clarification.
-
You can download the working copy of the 1.5 code by using SVN and grabbing the "devel" branch.
I haven't looked to see if this code has been incorporated yet. It's on the "to-do" list for 1.5 (on the dev-only board), and it hasn't been crossed off, so I'm thinking "no".
-
Thank you very much. It is appreciated.
-
kudos - nice mod!
very easy to install!
worked first try!
:)
xx-07