forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Tranz on September 19, 2004, 11:41:04 pm

Title: style changes for font consistency
Post by: Tranz on September 19, 2004, 11:41:04 pm
When I looked at the group manager, the alternating rows had different font sizes, which threw off the vertical alignment of the radio buttons. It turned out that since my theme is based on Project, which is similar to MacOS, I found the same styling settings that caused the issue.

In Project vii's style.css, .tableb needed the font-family attribute for it to match .tableh2.
Code: [Select]
.tableb {
        font-family:  Verdana, Geneva, Arial, sans-serif;
        background: #FFFFFF ;
        padding-top: 3px;
        padding-right: 10px;
        padding-bottom: 3px;
        padding-left: 10px;
}

The strange thing with MacOS theme is that the styles difference has nothing to do with font, but with the image background. When I added font-family to both tableh2 and tableb, things lined up.
Code: [Select]
.tableh2 {
        font-family:  Verdana, Geneva, Arial, sans-serif;
        padding-top: 3px;
        padding-right: 10px;
        padding-bottom: 3px;
        padding-left: 10px;
        background-image: url(images/tableh2_bg.gif);
}

.tableb {
        font-family:  Verdana, Geneva, Arial, sans-serif;
        padding-top: 3px;
        padding-right: 10px;
        padding-bottom: 3px;
        padding-left: 10px;
}

Title: Re: new "groups manager" in cpg1.4
Post by: Joachim Müller on September 20, 2004, 07:26:06 am
You're right, they appear in different fonts, but your solution is not a good alternative imo, as the font-families are already defined somewhere else in Mac_ox_x:
Code: [Select]
.tableh1, .tableh1a, .catlink, .tableh2 { font-family: Verdana, Geneva, Arial, sans-serif; }My suggestion would be to replace all instances of the font-family definitions and only use one for the body section (removing the line I posted completely, along with all other lines defining font-family except the one defining the body).
The same thing applies to the Project VII theme.
I committed my suggested changes to the devel version (mac (http://cvs.sourceforge.net/viewcvs.py/coppermine/devel/themes/mac_ox_x/style.css) and project (http://cvs.sourceforge.net/viewcvs.py/coppermine/devel/themes/project_vii/style.css)), please take a look into it and post your feedback (if it doesn't work, we could easily roll this change back). Thanks.

Joachim
Title: Re: style changes for font consistency
Post by: Joachim Müller on September 20, 2004, 07:27:51 am
see my reply to your posting in the groups manager thread: http://forum.coppermine-gallery.net/index.php?topic=8075.msg45628#msg45628

Joachim

[edit GauGau]
split/merged my reply to be part of this thread
[/edit]
Title: Re: style changes for font consistency
Post by: Tranz on September 22, 2004, 01:49:47 am
Thanks, it looks fine now.