forum.coppermine-gallery.net

Support => cpg1.4.x Support => Older/other versions => cpg1.4 themes/skins/templates => Topic started by: WickedElf on January 04, 2006, 04:43:29 am

Title: Validation problem
Post by: WickedElf on January 04, 2006, 04:43:29 am: I'm trying to validate the xhtml and coming across a problem.

On the index page, there is an extra opening bold tag. I thought it was because I had fiddled with the theme, but I went to the demo page (http://coppermine-gallery.net/demo/cpg14x/index.php?4x=&theme=classic) and spot checked a few skins (giallo, classic, hardwired) and found the same problem with all of them.

Code: [Select]
<td colspan="3" class="tableh1" align="center">253 files in 20 albums and 6 categories with 21 comments viewed 94124 times</td>
I've looked through index.php, english.php and theme.inc.php and couldn't find the extra bold tag. And

Code: [Select]
'stat1' => '[pictures] files in [albums] albums and [cat] categories with [comments] comments viewed [views] times',and
Code: [Select]
<td colspan="3" class="tableh1" align="center">{STATISTICS}</td>
Where can I go to find the necessary code to fix that?

Thanks!
Title: Re: Validation problem
Post by: Paver on January 04, 2006, 05:10:48 am: It's true that having , around {STATISTICS} makes the nested , tags moot (inside the $statistics variable), but is that a validation problem? I admit I don't know enough about XHTML compliance to answer that myself.

One way to remove this issue for merely validation-sake is to make a copy of english.php, remove the nested , tags and set your language to this new english.php. You could also hack themes.inc.php, but that's not recommended since it's a core script. Instead, override $template_cat_list in your theme.php by copying that variable from the sample theme and removing the , around {STATISTICS}. On second thought, I would lean toward the latter solution unless you really want the entire {STATISTICS} text to be bold.

To clarify: don't modify themes.inc.php since nearly everything can be overridden in your theme's theme.php. (If you are using a core theme, copy the theme to a new folder and set your theme to this new one, then customize it.)
Title: Re: Validation problem
Post by: WickedElf on January 04, 2006, 05:22:17 am: I removed the nested tags, and that does allow validation now. I didn't remove it before because I was actually misreading the line too and thought it was missing a closing bold tag and that there was the problem... not the redundancy. :-\ Man, usually I catch myself before I ask really stupid questions on forums, and now I've asked at least 2 or 3 dumb ones on this forum alone. I'll have to blame it on the post-holiday chaos. *sigh*

Quote
It's true that having , around {STATISTICS} makes the nested , tags moot, but is that a validation problem?

Apparently. ::)

Thanks!
Title: Re: Validation problem
Post by: Paver on January 04, 2006, 05:32:37 am: Since that is a validation issue, your post has usefully reported a redundancy in the core themes.inc.php script, which offsets your blindness to that poor closing bold tag.