Support > cpg1.5 bridge contributions
Bridge for Joomla 1.5 ready
extrabigmehdi:
@Joachim Müller ,
--- Quote ---I must confess that I'm a complete novice when it comes to Joomla, so please bare with me.
--- End quote ---
For your information, Joomla! has a small learning curve. It's currently the easiest CMS to use (with its "predecessor" Mambo).
And also it has quite enough flexibility for most people. I think even Microsoft is annoyed by Joomla, since recently I saw an article bashing Joomla! , but full of lies (and answer by "Joomla community"). So now you should be curious, and try it ... ;)
@Phill Luckhurst
--- Quote ---It is so good to see that you are continuing development to coppermine 1.5 as I would be lost without your efforts.
--- End quote ---
Fortunately, it was easy enough for me to port old bridge to new version of CPG 1.5 . I've heard that the release of CPG 1.5 might be imminent, so I tried to release bridge a bit in advance.
--- Quote ---I'm sure if you included these links in the plugins details then you could increase traffic to your site.
--- End quote ---
For the moment I don't have the mind to think about this. Even if the bridge is included in Coppermine package, it might need to be updated.
Just recently I've added for instance a better support for community builder users (no more hacks for them).
About the PHPMailer issue:
I've noticed some difference between the class used by Joomla & Coppermine.
Joomla: version used is 1.73, and charset utf-8.
Coppermine: version used is 2.0.3 , and charset iso-8859-1
Anyway it's a relatively minor issue, since lot of people used before my bridge, and only one user reported by mail he got a problem.
I hope no other class/function conflict will be discovered.
Nibbler:
--- Quote from: Joachim Müller on March 21, 2009, 01:24:04 pm ---It should be safe to just rename the class, right?
Editing include/mailer.inc.php, finding
--- Code: ---$mail = new PHPmailer();
--- End code ---
and replacing that string with
--- Code: ---$mail = new cpg_PHPmailer();
--- End code ---
Then find
--- Code: ---class PHPMailer {
--- End code ---
and replace with
--- Code: ---class cpg_PHPMailer {
--- End code ---
Taking a closer look: we have another class named SMTP that might be there two times, so we'd have to rename that as well.
--- End quote ---
Yes, both need renaming.
--- Quote from: Joachim Müller on March 21, 2009, 01:24:04 pm ---Why not? They use PHPmailer as well. Couldn't we just wrap the two classes into corresponding if (!class_exists('class_name') {-code and get away with that? After all, the users of the joomla bridge warp "our" gallery into an entire CMS - the CMS should know what it is doing anyway.
--- End quote ---
Our copy has changes for Inspekt plus an additional SMTP bugfix that's not in the official PHPMailer release. Theirs probably has changes too. Plus the fact that we may ship totally different versions of the class to each other. It's just asking for trouble to blindly use code we don't control.
Joachim Müller:
OK, so it's the renaming-schedule. I'm not sure about the impact of renaming the smtp class though, and I currently can not test SMTP. Should we just blindly change without testing or do you have the opportunity to test a renamed SMTP class?
extrabigmehdi:
@Joachim,
I think renaming will have zero impact on how Coppermine works.
I just made a search though all Coppermine files, and the string "PHPmailer"
is only used on the file mailer.inc.php .
Joachim Müller:
--- Quote from: extrabigmehdi on March 22, 2009, 01:03:02 pm ---I just made a search though all Coppermine files, and the string "PHPmailer"
--- End quote ---
I have done so before, I know that. That's why I said
--- Quote from: Joachim Müller on March 21, 2009, 01:24:04 pm ---Editing include/mailer.inc.php, finding
--- Code: ---$mail = new PHPmailer();
--- End code ---
and replacing that string with
--- Code: ---$mail = new cpg_PHPmailer();
--- End code ---
Then find
--- Code: ---class PHPMailer {
--- End code ---
and replace with
--- Code: ---class cpg_PHPMailer {
--- End code ---
--- End quote ---
The word "SMTP" occurs much more often in the code - sometimes as class name, sometimes not. That's why I said
--- Quote from: Joachim Müller on March 21, 2009, 01:24:04 pm ---Taking a closer look: we have another class named SMTP that might be there two times, so we'd have to rename that as well.
--- End quote ---
SMTP is the trickier part.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version