Only a couple of minor issues. There is currently no button to return a pic from fullsize to intermediate ( minimize?).
I agree that this would really be a cool feature. @Timo: any plans to implement that?
In enl_bbcode.php, there's this line:
if (eregi("MSIE",$_SERVER['HTTP_USER_AGENT'])) $isie = 1;
I think it must have something to do with Inspekt / superglobals. Seems as this line must be changed somehow...
Fixed.
The following issue seems to be present inside the original code- Rounded corners don't seem to work with border background images
Please see EnlargeIt! documentation page 8 enl_brdround.
Hehe, I agree that I have deserved to be told to RTFM, but in this aspect I don't think you're right (apart from the fact that the section is on page 7 for me). I understand that rounded corners are a gimmick that only work with particular browsers. Of course I was using one of those supported browsers when I wrote my bug report: what I was trying to say that the rounded corners work fine if you use a monochrome background, but stops working when using a background image. I'm not sure if this is a bug in the script or a missing feature or a known issue for the entire rounded-corners-technology; it's just meant as a report, that's all. There is no note in the docs you refered to about this, that's why I don't think that your mentioning the docs applies in this aspect.
- snippet add to favourites gives a critical error page
can not replicate
- snippet download of file doesn't work at all
Haven't looked into the download feature yet, but it certainly needs reviewing. I'll do so as soon as I've finished working on the open histogram issues.
- histogramm isn't viewed
Can't replicate
- 'maximize as popup' doesn't work
I'm aware of that - see my note on the admin screen: the feature is needlessly complicated, as we already have the corresponding permission flags built-into the core. That's why I'll need to look into this feature to make it work flawlessly both with coppermine as well as for your standalone version.
- doesn't work an album list page because of these lines in codebase.php
Changed that, but not in the way you proposed. Using
if ((defined('INDEX_PHP') && !defined('DISPLAYIMAGE_PHP')) || defined('THUMBNAILS_PHP')) {
is a very bad idea: those constants exist for the sake of i18n only. They are not unique. To determine what file you're in, use $CPG_PHP_SELF. Under no circumstances should you use the code you proposed.
- transparent AJAX loader ani is taken from theme, looks really ugly in my eyes and isn't visible good enough
That's a matter of taste. Minor issue if you ask me. I'll see to add your loader back in, but I do not believe that plugins should come with proprietary styles of their own; instead, they should respect the styles of the theme used.
- copyright on plugin page: I changed my name this year, see here
Changed that as suggested. I wasn't aware of it though: your old name still shines through in the JS files and credits of enlargit (standalone) - you might want to correct that.
@all testers: please keep in mind that you need to uninstall an old version first, then delete the enlargit plugin folder, then upload the new enlargeit fodler, then install the new version of the plugin again using the plugin manager. Just updating the files is not enough, as the database changes are only being performed during plugin install/uninstall.
The database part of the plugin is currently changing a lot, as I have been adding options...
Cheers
Joachim