Please restore the original comments in the JS files for the same reason. I think the line "This comment MUST stay intact for legal use, so don't remove it." says it all.
As far as I can see the comment is still in the file, at the very top. I'm very picky with such issues, that's why I haven't removed that first line, but converted it just to sit inside the "regular" header. But if you're not fond of that I will of course go back to the original method, with the shorter credits at the top.
The EnlargeIt! javascript is a seperate product. To ensure that users of the plugin can safely use the latest javascript version at any time in order to benefit from bug fixes and new features, it's essential IMO to not change anything inside enlargeit.js and enlargeit_source.js. This means, the 'standard' way of setting Javascript variables inside of cpg1.5 should not be used in this case. Parameters should be modified by embedding the script and directly after it setting the variables as desired.
I can see your point and of course I will respect it. Please give me some days to roll my changes back and come up with a solution that will work with the enlargeit.js out of the box.
However, I'm concerned that the method you propose to use will have a negative impact on the caching performance of the enlargeit script in the long run.
I agree to undo my edits inside the core of the script for the said reasons, but I'd really like you to review the following proposal: you already have a line inside
enlargit_source.js that reads
// stuff to leave alone
. I suggest renaming that to "do not edit below this line". All edits of the JavaScript file should come before that line. They could be used to "translate" the variables from external scripts like I did partially with lines like
var enl_brdsize=js_vars.enl_brdsize
This way, the third party app (coppermine in this case) will not interfere with the way that enlargeIt works in the first place.
Another thing I suggest to review is the way you handle the array for the buttons: it's not that intuitive to come up with custom features or custom buttons as long as you stick to one single icons graphic that you chop into bits script-wise: I understand that there can be a slight performance penalty for single images (instead of the script only having to load one monolithic image) to be used as buttons, but I guarantee that there will be only very few non-coppermine users who will be ready to look into enlargeIt in detail just because of the handling of the icon bar.
Gongrats for your documentation though: it's excellent. I suggest making it available as an HTML document as well for better results in search engine ranking.
Joachim