Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Ban expiry  (Read 9114 times)

0 Members and 1 Guest are viewing this topic.

Nibbler

  • Guest
Ban expiry
« on: September 22, 2004, 01:45:54 am »

Bans don't seem to be expiring for some reason. I think it's to do with different date formats or something else beyond my comprehension. Anyone else getting this problem ?
« Last Edit: October 24, 2004, 03:25:35 pm by GauGau »
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: Ban expiry
« Reply #1 on: September 23, 2004, 02:18:14 am »

I tested banning by choosing yesterday for the expiration date. When I logged in as the banned user, I got the banned message both in v. 1.3.2 and 1.4.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Ban expiry
« Reply #2 on: October 23, 2004, 11:26:58 am »

fixed in devel cvs by editing include/init.inc.php and changing the ban expiry part of the code to
Code: [Select]
// Remove expired bans
$now = date('Y-m-d H:i:s');
cpg_db_query("DELETE FROM {$CONFIG['TABLE_BANNED']} WHERE expiry < '$now'");
Committed changes to devel cvs. Please check out and confirm. If fix works for you, changes should be applied to stable as well.

Joachim
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: Ban expiry
« Reply #3 on: October 23, 2004, 09:45:24 pm »

It works now.

I would suggest that if someone selects a date that is either today or earlier, they get a notification telling them they must select a date in the future. As it is, the page just sits there. When I went back to the ban page, that ban entry had disappeared.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Ban expiry
« Reply #4 on: October 24, 2004, 03:24:50 pm »

"intelligent" date selection is a feature that should be considered, that's why I added it to the todo list. As the initial bug this thread was about is solved I tagged this thread as "fixed".
I committed the changes mentioned above to the stable cvs as well.

Joachim
Logged
Pages: [1]   Go Up
 

Page created in 0.03 seconds with 19 queries.