forum.coppermine-gallery.net
Support => cpg1.5 plugins => cpg1.5.x Support => cpg1.5 plugin contributions => Topic started by: loungelizard on January 26, 2010, 10:35:22 pm
-
I've played around with Coppermine a while and implemented two functions I liked from Pixelpost-Addons I've tried out before.
The Plugin serves two purposes:
- provide Geotag support for Coppermine
- provide histogram suppport for Coppermine
Geotag support:
Upon installation a new table is generated into the coppermine schema. This table holds all the EXIF data from
images it can find. Right now, I'm extracting more data than I use for the geotagging feature. I don't know
yet what to do with them in the future ;-)
The EXIF-Data are pulled from images upon upload. If you want to generate the EXIFs from all the existing
images in your database, a special function is nested inside the Plugin-Manager page.
Upon displaying of an image, it is checked, whether Geotag-Data is inside the plugin's table. If the
required Geodata exists, an icon is displayed that can be clicked to open the location in a
Google Maps view. If no Geodata is available, you can choose to hide the image or display an image without
a link.
Histogram support
If activated a histogram is created upon upload of an image. The settings are fully configurable.
All histograms are stored in the original file directory and have a filename
hist_<coppermine_id><original filename>.jpg
Histograms can be generated upon upload of new images or on demand, in case someone clicks on the corresponding button.
Please try the plugin out and give me feedback. I know it's not completely ready so please, if you encounter any problems, leave a post in this thread and I'll look into it.
Be sure to read the readme for full details regarding configuration.
Regards, Florian
==============================================================================================================
Credits
==============================================================================================================
- This plugin for Coppermine was inspired and is in part based upon "easyMap for Pixelpost" by http://maximee.de
- Credits to Doug Pillow for the geodata conversion algorithm http://www.weberdev.com/get_example-3548.html
- Credits to eenemeenemuu for his fav_button Plugin that showed me how to add buttons to the navbar
- The function to generate the histograms was adapted from the Pixelpost addon by Kevin Crafts http://blog.kevincrafts.com/
- The configuration screen uses the farbtastic color picker by Steven Wittens http://acko.net/dev/farbtastic
==============================================================================================================
v1.9 - Fixed a bug that caused not to show geobutton, if geo-coordinates showed a zero value.
v1.8 - Fixed the bug that geotags were not extracted when using the watermarking feature. This only
works, if the original image is residing in the same folder as the watermarked image.
v1.7 - changed the way displaymap was called for the Google maps to make it similar to the albumview
- Fixed a bug in the config menu regarding a the new parameter.
- Fixed the nasty bug that caused the problems with the swf-uploader. SWF Upload works fine again when my plugins are installed :-)
-
Thanks for your readiness to share. Well done for your first plugin, I'm really impressed.
There already is a plugin that generates histograms - see EnlargeIt! AJAX GUI for CPG 1.5.x (http://forum.coppermine-gallery.net/index.php/topic,57424.0.html); I don't think that it's a good idea to create a load of files within one folder. This will no doubt crash bigger galleries, especially since the histogram is created in one big bulk. I find your histogram much more beautifull though than the one I refered to.
I have reviewed your plugin and changed some things (for coppermine coding guidelines compliance). Please don't get me wrong: your plugin is great and much appreciated. I'm posting this for the benefit of plugin authors:
- use the new feature to determine the min requirements for plugins - see http://documentation.coppermine-gallery.net/en/dev_plugins.htm#plugin_writing_core_files_configuration_plugin_cpg_version
- The zip archive needs to contain the folder, as newbies will not understand that they have to put all plugin files into a name with a particular folder that can not be changed
- There are naming conventions for files, see http://documentation.coppermine-gallery.net/en/dev_plugins.htm#plugin_writing_naming_conventions
- The layout of the language files has changed from cpg1.4.x to cpg1.5.x - I edited it accordingly
- Never let your PHP files end in .inc - always name them .inc.php for security reasons!
- Use the table prefix as suggested in http://documentation.coppermine-gallery.net/en/dev_plugins.htm#plugin_writing_database_tables_access
- Don't use deprecated HTML - tags like <hr> are bad!
- Sadly, you have based your config screens on the worst examples of those files - I'll look into it asap
Once again, thanks for your contribution.
Is it OK to add your plugin to the subversion repository?
Joachim
-
Hi Florian,
thanks a lot for sharing your new plugin!
Why did you implement Lytebox additionally, as we already have greybox integrated in Coppermine (to display the help system)? Should be equal in function, avoids another javascript to be loaded, and would keep the look and feel.
-
Hi Timo,
thanks for the info and yes, you're right, I should try to avoid putting additional things in it. I'll look into dropping lytebox and changing it to greybox in a future version.
Regards, Florian
-
Hi Joachim and thanks for your hints. Please do add the files to the repository, I'll start working from there as soon as I can, I may need some pointers on how to set everything up but I believe in the strength of the community to get this all done even better.
Regarding the histogram function: I plan on changing it to an on-demand-generation, so that the histogram is only generated if you really want one, so only the first person to click on the link has to wait while the histogram is being generated. Do you have a better idea in mind, what to do?
The credits for the histogram goes to Kevin Craft and his fine work for the Pixelpost addon. I merely adapted it to Coppermine.
I'll look into the changes you suggested as soon as I get the chance. - I didn't get the remark about the config file though, can you rephrase?
Regards, Florian
-
Please do add the files to the repository
Great, thank you. I have added the plugin to the svn repository. Web SVN access: http://coppermine.svn.sourceforge.net/viewvc/coppermine/branches/cpg1.5.x/plugins/flf_histotag/
Regarding the histogram function: I plan on changing it to an on-demand-generation, so that the histogram is only generated if you really want one, so only the first person to click on the link has to wait while the histogram is being generated. Do you have a better idea in mind, what to do?
That's exactly the mechanism I had in mind and how I implemented this for the enlargeIt plugin: in an early version, the histgoram used to be created in a sub-folder of the plugin. This is of course not a good solution: all files related to the content should reside inside the albums folder. That's why the histogram files created by the enlargeit plugin get created in the very folder where the original files reside in; they just get prefixed accordingly. I suggest to use a slightly different prefix name for your plugin. When a histogram file is needed, the plugin checks if that file already exists and creates it if it doesn't. Additionally, I have come up with a nifty cache control for those who are short on web space: you can control the amount of webspace that the histogram files are allowed to consume in total. I'm not sure if this feature will be actuall used a lot (I doubt it), as the histogram files don't eat much space in the first place, so I basically implemented it as a proof-of-concept.
I didn't get the remark about the config file though, can you rephrase?
You appear to have based the way you coded the plugin configuration screen on a plugin where this has not been done in an ideal way - that's why your plugin's config section differs very much from the look of what I would call an ideal config screen. We have written down some remarks on the usability of forms inside the docs: http://documentation.coppermine-gallery.net/en/dev_coding.htm#dev_coding_usability_forms
Plugin writers are encouraged to review that section carefully. If you want to get an impression of what we consider to be a good config screen in terms of usability, take a look at the thumb_rotate plugin (http://forum.coppermine-gallery.net/index.php/topic,57468.0.html) or the enlargeit plugin (http://forum.coppermine-gallery.net/index.php/topic,57424.0.html) (screenshots attached). Anyway, what I really suggested was that I would take care of that config screen (if you agree) and have that "pimped" in the way I pimped the config screen of the other two plugins.
I have added your plugin to our download section at sourceforge as well: http://sourceforge.net/projects/coppermine/files/Plugins/1.5.x/cpg1.5.x_plugin_flf-histotag_v1.0.zip/download
Cheers
-
Great, thank you. I have added the plugin to the svn repository. Web SVN access: http://coppermine.svn.sourceforge.net/viewvc/coppermine/branches/cpg1.5.x/plugins/flf_histotag/
How do I get write access to the svn? My sourceforge id is loungelizard99. Or do you only grant write access to the core team; if so: How do I submit changes?
Anyway, what I really suggested was that I would take care of that config screen (if you agree) and have that "pimped" in the way I pimped the config screen of the other two plugins.
Thanks for that offer, I'd appreciate your help. I'm already in the process of changing some of my files so if you can avoid changes to any of the files but the configuration screen, I don't get confused when putting it all together.
Regards,
Florian
-
How do I get write access to the svn? My sourceforge id is loungelizard99. Or do you only grant write access to the core team; if so: How do I submit changes?
You already anticipated it: we only grant write access for dev team members. Just check out the subversion repository, perform your changes, then zip the plugin and re-attach it here - a dev team member will commit your changes in the zip file for you. This usually happens within a few hours after posting, as there are several active devs who perform that task.
Thanks for that offer, I'd appreciate your help. I'm already in the process of changing some of my files so if you can avoid changes to any of the files but the configuration screen, I don't get confused when putting it all together.
OK, great - I'll let you know about my changes.
-
Hi,
I'm in the process of putting in the changes as discussed above. Now I'm stuck with one problem which I'm sure you Coppermine-Gurus know the solution quickly to.
To generate the histograms on demand, i changed the mechanism from displaying an image with the histogram (which at that time had to be generated) to displaying a new php-page residing in my plugin folder called histotag_histogram_display.php which i pass the picture ID parameter to.
When opened, I want to check if the histogram-image exists, and if it doesn't (and configuration is set to do so) generate the histogram on the fly and then displaying it in the html output.
All auxiliary functions are inside include/histotag_histogram_support.php.
The problem I'm having now is that obviously this file .._display.php runs outside the coppermine focus so I don't have access to the required core functions.
I tried to resolve this by putting in
define('IN_COPPERMINE', true);
require('../../include/init.inc.php');
require ("include/histotag_histogram_support.php");
in that file, but with those relative paths the includes inside init.inc.php fail, cause they go from the coppermine-root-directory.
What do I have to do to set the context right, so I can include the init.inc as well as other files from an auxiliary page that resides inside my plugin folder?
Regards, Florian
-
Just call the script with index.php?file=flf_histotag/histotag_histogram_display instead of calling it with ./flf_histotag/histotag_histogram_display.php.
-
Hi André and thanks for your quick response. I get the page started this way, thank you. However, now I have the problem of needing to transfer information to the new .php-file, the Picture-ID in particular. I don't seem to be able to pass it with a regular parameter, cause the index.php strips those away and the $CURRENT_PIC_DATA-array is empty inside my newly opened file (I did include it with GLOBAL).
Do you have another pointer for me as to how to get a value passed to my file?
Regards, Florian
-
solved it by using the $_SESSION-array until I find something better. Now I just have to clean up some code fragments so I can release the updated plugin later today.
-
Version 1.1 released.
Major changes:
- Renamed files according to coding conventions
- Changed Tablename according to naming conventions
- Removed lytebox for displaying pictures, substituted with greybox - thanks to 'TimosWelt' for the hint
- Histograms are now being generated on demand only when the histogram button is clicked. This way the system doesn't get cluttered with histograms that noone is interested in seeing. Downside: first time to call the histogram takes some time.
- Changed Histogram quality to 75% to get smaller filesizes
Please see readme on instructions how to upgrade.
Cheers, Florian
-
Committed changes in r7165.
- The zip archive needs to contain the folder, as newbies will not understand that they have to put all plugin files into a name with a particular folder that can not be changed
-
I get an SQL error when trying to "Generate all histograms (DANGER!)":
While executing query 'SELECT t.pid, t.filepath, t.filename FROM cpg15x_pictures t WHERE t.pid not in (SELECT pid from cpg15x_ );' in plugins/flf_histotag/include/histotag_histogram_support.php on line 192
mySQL error: Table 'db166218_7.cpg15x_' doesn't exist
and I get another SQL error when trying to "Gather exif from all files!"
While executing query 'INSERT into cpg15x_plugin_flf_histotag VALUES ('21','','','','','','','','','','','','','','','','','','','','','','','','','','','',,'','','','','','')' in plugins/flf_histotag/include/histotag_support.php on line 143
mySQL error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''','','','','','')' at line 1
-
Fixed the one in the generate histogram function (missed one string replacement). The other one seems to be related to the specific file that you have in your database. Can you provide me with the original file that corresponds to your ID #21? I've seen this error on one of my images before, too but I can't find the file anymore ;) It's working fine on my testbed and live system.
Thanks.
Cheers, Florian
-
The file is here:
http://pics.timos-welt.de/displayimage-21.html
Have a look at the filename, I assume it's the ( and ) that breaks it.
-
No, it must be something that resides inside the exif information; double checked it to be sure. I don't use the filename for anything related to that part. Can you give me access to the original file?
-
http://pics.timos-welt.de/albums/uploads/orig_Eppe_20060701_%286%29.jpg
-
fixed in Version 1.2.
Thanks for your help.
-
Committed version 1.2 in r7169.
-
However, now I have the problem of needing to transfer information to the new .php-file, the Picture-ID in particular. I don't seem to be able to pass it with a regular parameter, cause the index.php strips those away
I can not replicate: using http://yoursite.tld/your_coppermine_folder/?file=flf_histotag/histotag_histogram_display&foo=bar&bla=whatever should work no matter what, so you should be able to get the pid as well via URL parameter (as an example for a lot of parameters in the URL, take a look at http://coppermine.svn.sourceforge.net/viewvc/coppermine/branches/cpg1.5.x/plugins/fetchcontent/js.php?view=log)
solved it by using the $_SESSION-array until I find something better.
You should change that, as sessions don't work reliably.
the $CURRENT_PIC_DATA-array is empty inside my newly opened file (I did include it with GLOBAL).
It's empty because there is no current pic if the script isn't aware of a pid. If you have the pid, you can always use the function get_pic_data to fetch the details.
-
Well I tried to get any result out of the latest version, but failed.
The button 'Generate all histograms (DANGER!)' doesn't work for me at all because of server timeout limits (this should be changed IMO - there's no danger in doing this like on admin tools page).
I never saw a histogram button, no matter what setting I used.
The settings for viewing the buttons even if there's no histogram file or geo data don't work for me. I still have to see a button.
The config setting 'Show button even if no geo data was found' always switches back to 'show', no matter what I set it to. Same applies for 'Show button even if no histogram is found'.
The setting 'Show histogram with every image(will be generated on the fly if necessary)' doesn't do anything, either.
-
The plugin tries to create a folder named "histograms" in coppermine's root folder (which is of course a very bad place for such a folder, as indiciated earlier). If it doesn't have permission to do so, it will fail with an error message. Maybe that's what happened for you.
-
Hi Timo,
did you see histograms created in the "root/histograms" folder after selecting the corresponding function? As a matter of fact, do you see the root/histograms folder at all? The "Generate all histograms" function is not required if you you toggle the "on-demand"-generation - but from what I'm reading you don't seem to see the buttons at all, which is strange.
Regarding the config screen: I'll look into this... frankly I didn't put any more effort into it after Joachim said the config screen was based on a bad example. @Joachim: Did you put any effort into it? If you didn't so far, I'll generate a new ones based on one of the plugins you suggested. I just want to make sure, you didn't start something that I might override otherwise.
At any rate, I'm surprised it doesn't work for you at all. Can you select your settings from the Config table for me and post them here or send via email?
SELECT * from <databasename>.<coppermine_prefix>_config where name like "flf%"?
(I'll change the parameters to the <plugin_flf_%>-alternative in next version too.)
If you all agree it's wiser to generate the histograms in the same folder, the actual files reside in, I'll change that in the next version.
Cheers, Florian
-
Yes the folder exists, and yes there are histogram files in it! A shame that I never was able to get one displayed :(
You should listen to Joachim; IMO he does great config pages and knows a lot about coppermine. In the end, the folder solution will work fine for small galleries with up to 500 files, but it won't work as well for galleries with 10,000 files.
-
@Joachim: Did you put any effort into it? If you didn't so far, I'll generate a new ones based on one of the plugins you suggested. I just want to make sure, you didn't start something that I might override otherwise.
Please go ahead and start working on it if you have the time. I have some suggestions though:- Having two config options "Show button in navbar if geo data found" and "Show button even if no geo data was found" is not a bright idea. Turn that into one config setting, using radio buttons. The label should read "Show geo data button in navbar?" and the possible options should imo be "Always", "Only if image contains geo data" and "Never". A similar thing applies for the histogram button
- The option "Size of lytebox window" exists twice. I suggest dropping both of them and using the greybox as it is.
- Plugin tablename (usually don not change this!) - drop that option completely: the table name should be PREFIX_plugin_flf_histotag, with the PREFIX of course being the actual representation of $CONFIG['TABLE_PREFIX']
- The option "Type of histogram (combined/split)" mustn't be a text input field, but of course a radio button
- None of your dropdown selects should be used that way. Most of them can be turned into checkboxes
-
Version 1.3 is released. I've taken all the suggestions I got from this forum and put it into the new version. Most effort went in the new configuration but also some features have been added.
As always, I'm glad to get feedback from you.
To see the plugin at work please visit http://www.lounge-lizard.org/cms (http://www.lounge-lizard.org/cms)
Cheers, Florian
Full changelog:
[A] complete rewrite of the configuration screen
[A] added function to delete all histograms in the system in case you don't want them anymore or need to regenerate
[A] added parameter for image quality of histograms (1-100) in %; less quality makes smaller file size
[A] added options to change the Google map style (satellite, regular etc.)
- Histograms are no longer stored inside the histograms folder; instead they are stored in the samefolder the picture resides in.
[C] changed all parameters names according to coding conventions
[C] sanitized the passing of the pid-parameter to the display-histogram function; thanks to GauGau for the hint
[C] removed setting for changing tablename
[C] changed configuration options for geosupport so it is clearer, what they mean.
[D] eliminated most of the language-specific texts
-
I have comitted your changes to the SVN (rev 7216). Thanks!
-
The latest version works perfectly for me. What a great plugin!
I've centered the display of the histogram in histotag_histogram_display.php by old-schoolish putting <center> tags around the image. But that's a question of personal taste.
Thanks very much!
-
Another idea for the future: Currently the plugin uses the original image to create the histogram. If an intermediate pic exists, it should be much faster (and generate much less server load) to use the intermediate size pic if one exists. The resulting histogram shouldn't really differ much, but the CPU time needed to generate it shrinks dramatically. In the end it's just a small change in function checkandcreatehistogram().
-
I've centered the display of the histogram in histotag_histogram_display.php by old-schoolish putting <center> tags around the image.
The <center>-tag is deprecated. I suggest using <div style="text-align:center"> instead for validity reasons.
-
Another idea for the future: Currently the plugin uses the original image to create the histogram. If an intermediate pic exists, it should be much faster (and generate much less server load) to use the intermediate size pic if one exists. The resulting histogram shouldn't really differ much, but the CPU time needed to generate it shrinks dramatically. In the end it's just a small change in function checkandcreatehistogram().
That is a bright idea. Thanks for the input. I couldn't think of a way how to decrease the calculation time cause it does take quite some time to loop through every file... especially disturbing when debugging ;)
I'll look into it asap.
Cheers, Florian
-
Commited in Version 1.4 (see first post for download)
I played around with the intermediate images a bit and decided to even include an option to use the thumbnails as source for the histograms. Lightning fast but the differences in accuracy are really noticable. See the attached examples from a sample image.
Additional changes:
- fixed a bug that left some pictures without geobutton even though geodata exists
- fixed a bug regarding include files
- fixed the link to the farbtastic colorpicker images in the config screen
- centered the histogram during output
- Using intermediate or thumbnail size images for the histogram calculation in case they exist. This dramatically increases performance, the output quality is not really affected that much when using the intermediate image. It does however make a bigger difference when using the thumbnails.
- Decide for yourself: accuracy vs. speed
- added a setting in the configuration screen for the above option
- Changed the icons supplied with the plugins to "Silk icon set" by www.famfamfam.com
- Fixed a bug that plugin information did not show in plugin manager, when plugin not yet installed
Have fun, Florian
-
- Changed the icons supplied with the plugins to "Silk icon set" by www.famfamfam.com
Bundling with the silk icon set can be tricky (license-wise). I suggest using the crystal_clear set by Everaldo instead (see http://documentation.coppermine-gallery.net/en/credits.htm#codebase and http://forum.coppermine-gallery.net/index.php/topic,57075.0.html).
Commited in Version 1.4 (see first post for download)
The term "commit" usually means "checking in into the subversion repository" in this aspect. I have done that for you.
-
Please make note of the newest addition to my histotag plugin. Please see first post for download link.
Please visit http://www.lounge-lizard.org/cms/coppermine/index.php?file=flf_histotag/mapalbum&aid=9 (http://www.lounge-lizard.org/cms/coppermine/index.php?file=flf_histotag/mapalbum&aid=9) for an example.
The following features have been added in Version 1.5.
[A] added a feature to include a map to BING instead of Google; Can be used without a bing api account.
If available, it uses the pretty "bird's eye view". If bird view is not available, a regular satellite image is used.
[A] added a new feature: Shows all geotagged images from an album on a Google map.
The new file "flf_histotag/mapalbum.php" can be called with parameter aid
If the user is allowed to view the album, the entire album is searched for images that contain valid geotags
For each image, a marker is located on a googlemap, that display a small popup-window from where you can
link to the displayimage.php for the corresponding image
Additionally, a sidebar is added to the map that shows all the images that markers were set for. You can
click on these thumbnail images to open the info window for the marker as well.
The map is centered and zoomed to fit all markers on the map. If you have a album with images from all
over the world, you'll get a smaller zoom level as if you have the images together that are from a close
perimeter.
A link to the map is available on the thumbnails.php or displayimage.php page - right after the breadcrumb
Note: This link is only available if a valid album number can be identified, thus it doesn't work yet for metaalbums,
search results etc.
Note: This function only works with Google maps, therefore you must have your own API key.
The style of the album map is determined by the same parameter as the regular map. If you use the
bing maps for the regular image view, the topographic view from Google is used in the
album view.
[A] The size of the album map is set by two new parameters.
If anyone has a better idea on where to link to the page besides the breadcrumb-Function in thumbnails.php and displayimage.php please toss me the idea. I couldn't think of a better way than including the text link as shown in the screenshots, but I'm not completely convinced yet.
Here are some screenshots.
Regards, Florian
-
Very nice and very impressive work!
Since you seem to be very prolific with your output I hope you could consider adding these 2 features. One should be relatively simple and straightforward, the second might not be possible or would require new plugin hooks and/or a lot of work.
1) Could you add these selections to the Plugin configuration for map types?
- Terrain Map (usually presents a very "clean" appearance)
- GMenuMapTypeControl - will present the visitor with a drop-down menu to select map type (has limits)
2) For those of use with older cameras and very much older photographs. Would it be possible to add a reverse geo-tagging feature? Perhaps within edit_one_pic.php or on a dedicated page?
Very cool plugin - nice work.
-
The histogram button shouldn't be visible for non-images. Currently it's even there for mp3 files.
-
Hi Joe and thanks for your feedback.
1) Could you add these selections to the Plugin configuration for map types?
- Terrain Map (usually presents a very "clean" appearance)
This one is already included (I presume you mean the G_PHYSICAL_MAP type? I named it "physical map" in the config screen; change that in the new version.) I did not find any other map type suitable for the plugin. It may be cause I'm still using the V2 of the Google maps API, V3 may offer some aditional things. See http://code.google.com/intl/de-DE/apis/maps/documentation/reference.html#GMapType (http://code.google.com/intl/de-DE/apis/maps/documentation/reference.html#GMapType)
- GMenuMapTypeControl - will present the visitor with a drop-down menu to select map type (has limits).
I added that function on my local testbed, works fine. After tweaking it a little bit I'll release later today.
2) For those of us with older cameras and very much older photographs. Would it be possible to add a reverse geo-tagging feature? Perhaps within edit_one_pic.php or on a dedicated page?
Gee I don't know. I geotag all my images with "geosetter" (http://www.geosetter.de (http://(http://www.geosetter.de)). This is a really fantastic tool that does the trick for me, even if I don't have GPS tracks to merge with my images. This of course would require you to re-upload the images after you add the geodata.
Geotagging the images inside coppermine would require a couple of steps
- Obtain the geo-coordinates for an image with a user-friendly interface
- Save these Coordinates in the original JPEG-Exif header ( I could of course only dump it into my plugin table, but i'd consider that a waste of effort on the user side)
- Retrieve the coordinates from the new Exif header to be able to display them.
I don't know if it's really worth the effort, especially the user-friendly-tagging part. I'll give it some thought.
Cheers, Florian
-
How about adding a "add location button" to each image. This could bring up a map where you could add the location. Once correct press another button to write to the db. Should be quite simple.
Here is a little example I knocked up of how the geocode could work in the back end.
http://www.windsurf.me.uk/geocode.html
As you can see, clickling on any location brings up the co-ordinates, simply add a button to accept that location and write to the db.
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8"/>
<title>Google Map Long/Lat finder</title>
<!-- Remember to change the keys for your own domain -->
<script src="http://maps.google.com/maps?file=api&v=2.x&key=ABQIAAAAXIIfOy9RqRn6Joxvjn0lIxR3sZnehZIYWrxGjIHvkcGdHqJv2BQnhafXU6ucIsJNlj4yLfWXwdSoTQ" type="text/javascript"></script>
<!-- Local Search scripts: AJAX Search (uds.js) and LocalSearch (gmlocalsearch.js) -->
<script src="http://www.google.com/uds/api?file=uds.js&v=1.0&key=ABQIAAAAXIIfOy9RqRn6Joxvjn0lIxR3sZnehZIYWrxGjIHvkcGdHqJv2BQnhafXU6ucIsJNlj4yLfWXwdSoTQ"
type="text/javascript"></script>
<script src="http://www.google.com/uds/solutions/localsearch/gmlocalsearch.js?adsense=pub-1022738694169855" type="text/javascript"></script>
<!-- Local Search styles -->
<style type="text/css">
@import url("http://www.google.com/uds/css/gsearch.css");
@import url("http://www.google.com/uds/solutions/localsearch/gmlocalsearch.css");
</style>
<script type="text/javascript">
//<![CDATA[
var map = null;
var geocoder = null;
function load() {
if (GBrowserIsCompatible()) {
map = new GMap2(document.getElementById("map"));
// create a local search control and add it to your map
var lsc = new google.maps.LocalSearch();
map.addControl(new GSmallMapControl());
map.addControl(new GMapTypeControl());
GEvent.addListener(map, "moveend", function() {
var center = map.getCenter();
document.getElementById("message").innerHTML = center.toString();
});
map.setCenter(new GLatLng(54.512161, -1.17523), 5);
geocoder = new GClientGeocoder();
}
}
function showAddress(address) {
if (geocoder) {
geocoder.getLatLng(
address,
function(point) {
if (!point) {
alert(address + " not found");
} else {
map.setCenter(point, 13);
var marker = new GMarker(point);
map.addOverlay(marker);
marker.openInfoWindowHtml(address);
}
}
);
}
}
//]]>
</script>
</head>
<body onload="load()" onunload="GUnload()">
<form action="#" onsubmit="showAddress(this.address.value); return false">
<p>
<input type="text" size="60" name="address" value="10 Downing Street,Westminster,London,UK" />
<input type="submit" value="Go!" />
</p>
<div id="map" style="width: 600px; height: 400px"></div>
</form>
<div id="message">(51.516514, -0.1342822)</div>
</body>
<li>
</html>
-
The histogram button shouldn't be visible for non-images. Currently it's even there for mp3 files.
Thanks for the info, I never thought about that. I added that check in the new version. I only control whether the button is active or not. If it's not a valid image, the button is now inactive.
If the button is visible at all will then still be decided by the appropriate plugin parameters.
Cheers, Florian
-
New version v1.6 with the proposed changes. See first post for download.
[A] Added an option to include the control on the Google maps pages to switch the map type
[A] Added functionality to make sure, that histogram button is only displayed when it's really an image.
(checks the valid image extensions to be certain)
Fixed a wrong link to the language files
-
Well done. You are indeed very prolific.
-
[A] Added functionality to make sure, that histogram button is only displayed when it's really an image.
(checks the valid image extensions to be certain)
We have a function for that purpose:
function is_image(&$file)
{
return cpg_get_type($file, 'image');
}
-
Hello Florian,
unfortunately, on my CPG 1.5.3 photo gallery under http://www.meyers-web.de after installing one of your (fantastic!) plugins (flf_histotag geotagging, flf_Zwitscher or flf_flashcloud) the upload via Flash works no longer:
Upload failed
Has someone already have the same problem?
Regards
merlin6666
-
Hi merlin,
now that you mention it: i do have the same problem... i never put it into context with my plugins :) I'll look into it asap.
Cheers, Florian
-
I'm clueless... I've checked the swfupload sources but as I'm unable to debug the steps inside the swf I don't really know where to check... the official documentation doesn't help much either:
SECURITY_ERROR - The upload violates a security restriction. This error is rare.
What the plugin does is adding a hook right after the upload is successfully finished - but as the swf upload fails the hook is never called.
Anyone having an idea as to where and how to check?
Cheers, Florian
-
Have you tried the debugger version of Flashplayer? The error messages will return more details than the standard version.
Flash Downloads page (http://www.adobe.com/support/flashplayer/downloads.html)
I think there are versions for most operating systems.
-
Hello Florian,
unfortunately, on my CPG 1.5.3 photo gallery under http://www.meyers-web.de after installing one of your (fantastic!) plugins (flf_histotag geotagging, flf_Zwitscher or flf_flashcloud) the upload via Flash works no longer: Code: Upload failed
Hi Florian,
any news about this issue? Would be nice, if you can solve it.
Regards
-
Hi Florian,
any news about this issue? Would be nice, if you can solve it.
Regards
I'm sorry. See me other post in the flf_flashcloud page. I can't identify the problem. Any help is appreciated. Cheers, Florian
-
I finally got some time to start digging around the problem and I think I figured out what was causing the problems with the shockwave-uploader (it should also fix the captcha-problem - i did not confirm this yet).
It was due to my language files for the German language being encoded in UTF-8. Once I changed that to UTF-8 without BOM (among some other issues regarding the use of the language files) it is now working for me locally on my testbed.
And the good part: I can reproduce the error by changing the encoding of the file. Still don't grasp the entire flow of the problem, but I'm glad I got it fixed.
Before publishing the fix (for this and also my other plugins) I'd be glad to send the updated files to some dedicated beta testers. Please contact me at my i-seek-u number 178.813.97 so we can work out the details.
Cheers, Florian
-
Please contact me at my i-seek-u number 178.813.97 so we can work out the details.
Why don't debug it publicly by attaching the changed files to your next reply?
It was due to my language files for the German language being encoded in UTF-8. Once I changed that to UTF-8 without BOM (among some other issues regarding the use of the language files) it is now working for me locally on my testbed.
No need for further testing imo, as this was most likely the cause.
-
The fixes have been uploaded and the new version v1.7 is available. It is attached to the first post in this thread. Please let me know, if there are any additional issues.
[ O] changed the way displaymap was called for the Google maps to make it similar to the albumview
[ B] Fixed a bug in the config menu regarding a the new parameter.
[ B] Fixed the nasty bug that caused the problems with the swf-uploader. SWF Upload works fine again even when my plugins are installed :-)
-
on new uploaded files there display no geodata in the pictures if the watermark-function in coppermine are enable.
please show the same problem in this thread -> http://forum.coppermine-gallery.net/index.php?topic=67143.0
-
Hi Florian,
Thanks to a good idea of a gf I searched a plugin to display a map with location (lat/long) for pictures of my website.
I tested several but your plugin is the better.
But a problem with your plugin was all pictures were already saved with data location.
It was not my case.
I wanted a solution like your plugin but with a module to save data location for every picture on a empty map (from google maps).
Then after some hours to work, i writed this module.
Here are the explanations :
Fields in the TABLE_CONFIG
I added 2 new fields in the TABLE_CONFIG in the script 'histotag_install.php' :
//Last geodata used By Pierre BASMOREAU (28/09/2010)
if (!$CONFIG['plugin_flf_histotag_lastlatitude']) {
$sql = "insert IGNORE into {$CONFIG['TABLE_CONFIG']} values ('plugin_flf_histotag_lastlatitude','0.000000')";
cpg_db_query($sql); }
if (!$CONFIG['plugin_flf_histotag_lastlongitude']) {
$sql = "insert IGNORE into {$CONFIG['TABLE_CONFIG']} values ('plugin_flf_histotag_lastlongitude','0.000000')";
cpg_db_query($sql); }
//End of last geodata
These fields save the last location used after creating geodata of an image.
Script "creategeodata.php"
This new script is placed at the root of your plugin and works only in the admin mode.
This script is based on code of this website : http://itouchmap.com/latlong.html
I cleaned this code to keep the essentiel.
a) For a picture WITHOUT geodata:
It displays an empty map (from Google Maps) just to locate the place of picture (the thumb is displayed under the map).
A submit button saves the current location of the marker into the table "plugin_flf_histotag" (fields : 'exif_GPS_GPSLatitudeRef', 'exif_GPS_GPSLatitude_1', 'exif_GPS_GPS_Latitude_2', 'exif_GPS_GPSLatitude_3', 'exif_GPS_GPSLongitudeRef', 'exif_GPS_GPSLongitude_1', 'exif_GPS_GPS_Longitude_2', 'exif_GPS_GPSLongitude_3').
b) For picture WITH geodata :
The same map is displayed but with the marker located in the lat/long from the picture. So if the location is bad, administrator can change it.
After saving the new location of picture, latitude and longitude are saved in these 2 new fields defined above.
This location is used to start a new location for a next picture near the previous.
Script "include/histotag_support.php":
I done some changes in the functions 'renderGeoButton' and 'GenerateLinkToMap'.
a) First, on function 'GenerateLinkToMap', I wanted that this function returns always a result with difference between 'user mode' and 'admin mode'. The link returned in admin mode is not used.
function GenerateLinkToMap($CoppermineID) {
// Generate a Link to the Google Map for the picture with the given $ID
// 1st read GPS EXIF-Data from Datbase
// IF exists, convert to decimal output for google Maps
// Then generate link to open new map
// New map is being generated with code from map.php
/******************************************************************************
DATE: 28/09/2010 By Pierre BASMOREAU
function returns always a link
******************************************************************************/
global $CONFIG, $flf_lang_var;
$query="select * from {$CONFIG['TABLE_PREFIX']}plugin_flf_histotag where pid='{$CoppermineID}'";
$vResult = cpg_db_query($query);
$array = mysql_fetch_assoc($vResult);
if ($vResult) {
// found data in table 'plugin_flf_histotag'
$lat_hour=flf_calc($array['exif_GPS_GPSLatitude_1']);
$lat_min=flf_calc($array['exif_GPS_GPSLatitude_2']);
$lat_sec=flf_calc($array['exif_GPS_GPSLatitude_3']);
$long_hour=flf_calc($array['exif_GPS_GPSLongitude_1']);
$long_min=flf_calc($array['exif_GPS_GPSLongitude_2']);
$long_sec=flf_calc($array['exif_GPS_GPSLongitude_3']);
// if data are ok calc latitude and longitude
if ($lat_hour && $lat_min && $lat_sec && $long_hour && $long_min && $long_sec) {
$flf_longitude =degree2decimal($long_hour."h".$long_min."m".$long_sec."s".$array['exif_GPS_GPSLongitudeRef']);
$flf_latitude=degree2decimal($lat_hour."h".$lat_min."m".$lat_sec."s".$array['exif_GPS_GPSLatitudeRef']);
$maplink = <<<EOT
plugins/flf_histotag/include/histotag_map.php?width={$CONFIG['plugin_flf_histotag_mapwidth']}&height={$CONFIG['plugin_flf_histotag_mapheight'] }&apiKey={$CONFIG['plugin_flf_histotag_apikey'] }&latitude={$flf_latitude}&longitude={$flf_longitude}&type={$CONFIG['plugin_flf_histotag_mapmode']}&showcontrol={$CONFIG['plugin_flf_histotag_changemaptype']}
EOT;
$returnvalues[0]=$maplink;
$returnvalues[1]=$flf_longitude;
$returnvalues[2]=$flf_latitude;
}
else {
// If admin mode = link on creategeodata.php (29/09/2010)
if (GALLERY_ADMIN_MODE) {
//maplink not used in this state. It is here just to return a value
$maplink = <<<EOT
plugins/flf_histotag/creategeodata.php?width={$CONFIG['plugin_flf_histotag_mapwidth']}&height={$CONFIG['plugin_flf_histotag_mapheight'] }&apiKey={$CONFIG['plugin_flf_histotag_apikey'] }&type={$CONFIG['plugin_flf_histotag_mapmode']}&showcontrol={$CONFIG['plugin_flf_histotag_changemaptype']}
EOT;
$returnvalues[0]=$maplink;
}
}
}
return $returnvalues;
}
b) Second, on function 'renderGeoButton' I wanted display a message on various cases :
- "No geodata for this picture" in user mode;
- "Create geodata for this picture" in admin mode if picture have no geodata;
- "View/Modify geodata" in admin mode when picture have location.
function renderGeoButton($template_img_navbar) {
global $CONFIG, $CURRENT_PIC_DATA, $FAVPICS, $REFERER, $lang_picinfo, $flf_lang_var;
$ref = $REFERER ? "&referer=$REFERER" : '';
switch ($CONFIG['plugin_flf_histotag_mapmode']) {
case '6':
$geo_tgt_return=generateLinkToBingMap($CURRENT_PIC_DATA['pid']);
break;
default:
$geo_tgt_return=generateLinkToGoogleMap($CURRENT_PIC_DATA['pid']);
$geo_tgt=$geo_tgt_return[0].$ref."#top_display_media";
break;
}
// $fav_tgt = "addfav.php?pid={$CURRENT_PIC_DATA['pid']}".$ref."#top_display_media";
/******************************************************************************
DATE: 28/09/2010 By Pierre BASMOREAU
$geo_tgt_return[0] returns always a link (see Function GenerateLinkToMap)
If geodata :
$geo_tgt_return[0] returns a link to show the place on map
$geo_tgt_return[1] et $geo_tgt_return[2] returns long/lat
If no geodata :
$geo_tgt_return[0] returns a link on 'creategeodata.php' only in ADMIN MODE
$geo_tgt_return[1] not exists
******************************************************************************/
// To test if geodata, add a clause $geo_tgt_return[1]
if ($geo_tgt_return[0] && $geo_tgt_return[1]) {
// GeoData found
//User mode ? ===> just show the map
if (!GALLERY_ADMIN_MODE) {
$geo_tgt=$geo_tgt_return[0];
$geo_title = $flf_lang_var['click_link'];
$geo_icon = "geo.png";
$geo_icon_hover = "geo.png";
$geo_button="
<script type=\"text/javascript\" src=\"plugins/flf_histotag/js/greybox_rightsize.js\"></script>
<td align=\"center\" valign=\"middle\" class=\"navmenu\" width=\"42\">
<a href=\"$geo_tgt\" flfwidth=\"{$CONFIG['plugin_flf_histotag_mapboxwidth']}\" flfheight=\"{$CONFIG['plugin_flf_histotag_mapboxheight']}\" class=\"flfbox\" title=\"{$flf_lang_var['notice']}\" id=\"geo_lnk\"><img src=\"plugins/flf_histotag/images/$geo_icon\" border=\"0\" align=\"middle\" alt=\"$geo_title\" id=\"geo_ico\" /></a>
</td>
<script type=\"text/javascript\">
$('#fav_lnk').mouseover(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon_hover'); } );
$('#fav_lnk').mouseout(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon'); } );
</script>
";
}
//Admin mode ? ===>view or modify geodata
else {
$geo_title = $flf_lang_var['view_modify_geodata'];
$geo_icon = "geo.png";
$geo_icon_hover = "geo.png";
$geo_button = "
<script type=\"text/javascript\" src=\"plugins/flf_histotag/js/greybox_rightsize.js\"></script>
<td align=\"center\" valign=\"middle\" class=\"navmenu\" width=\"42\">
<a href=\"javascript:;\" title=\"$geo_title\" onclick=\"return MM_openBrWindow('index.php?file=flf_histotag/creategeodata&id={$CURRENT_PIC_DATA['pid']}&latitude={$geo_tgt_return[2]}&longitude={$geo_tgt_return[1]}','Create GeoData','scrollbar=no,toolbar=no,status=no,resizable=no,width=700,height=500')\"><img src=\"plugins/flf_histotag/images/$geo_icon\" border=\"0\" align=\"middle\" alt=\"$geo_title\" id=\"geo_ico\" /></a>
</td>
<script type=\"text/javascript\">
$('#fav_lnk').mouseover(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon_hover'); } );
$('#fav_lnk').mouseout(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon'); } );
</script>
";
}
}
// Else no geodata
else {
if ($CONFIG['plugin_flf_histotag_geosupport']=='1') {
// if user mode = no link
if (!GALLERY_ADMIN_MODE) {
// show button only if parameter is set, otherwise: no button!
$geo_tgt="#top_display_media";
$geo_title = $flf_lang_var['no_data'];
$geo_icon = "nogeo.png";
$geo_icon_hover = "nogeo.png";
$geo_button = "
<td align=\"center\" valign=\"middle\" class=\"navmenu\" width=\"42\">
<a href=\"$geo_tgt\" class=\"navmenu_pic\" title=\"$geo_title\" id=\"geo_lnk\"><img src=\"plugins/flf_histotag/images/$geo_icon\" border=\"0\" align=\"middle\" alt=\"$geo_title\" id=\"geo_ico\" /></a>
</td>
<script type=\"text/javascript\">
$('#fav_lnk').mouseover(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon_hover'); } );
$('#fav_lnk').mouseout(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon'); } );
</script>
";
}
// if admin mode = show button with link to 'creategeodata.php'
else {
$geo_tgt=$geo_tgt_return[0];
$geo_title = $flf_lang_var['no_data_admin'];
$geo_icon = "nogeo.png";
$geo_icon_hover = "nogeo.png";
$geo_button = "
<script type=\"text/javascript\" src=\"plugins/flf_histotag/js/greybox_rightsize.js\"></script>
<td align=\"center\" valign=\"middle\" class=\"navmenu\" width=\"42\">
<a href=\"javascript:;\" title=\"$geo_title\" onclick=\"return MM_openBrWindow('index.php?file=flf_histotag/creategeodata&id={$CURRENT_PIC_DATA['pid']}','Create GeoData','scrollbar=no,toolbar=no,status=no,resizable=no,width=700,height=500')\"><img src=\"plugins/flf_histotag/images/$geo_icon\" border=\"0\" align=\"middle\" alt=\"$geo_title\" id=\"geo_ico\" /></a>
</td>
<script type=\"text/javascript\">
$('#fav_lnk').mouseover(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon_hover'); } );
$('#fav_lnk').mouseout(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon'); } );
</script>
";
}
}
}
$search = substr_count($template_img_navbar, "<!-- BEGIN pic_info_button -->") > 0 ? "<!-- BEGIN pic_info_button -->" : "<!-- BEGIN slideshow_button -->";
$template_img_navbar = str_replace($search, $geo_button.$search, $template_img_navbar);
return $template_img_navbar;
}
On every case, a particular link is called to view only location or to create/view/modify location by the script "creategeodata.php".
Files "lang/english.php" and "lang/french.php"
I added some messages in english/french to display messages in the correct langue :
// New messages (28/09/2010) By Pierre BASMOREAU
$flf_lang_var['no_data_admin'] = 'Create geodata for this image';
$flf_lang_var['save_geodata'] = 'GeoData saved successfull';
$flf_lang_var['center_marker'] = 'Center marker';
$flf_lang_var['view_modify_geodata'] = 'View/Modify geodata';
$flf_lang_var['submit_geodata'] = 'Tag picture';
// End of new messages
U can test this module on your website.
U can find these files attached here.
I hope my work will be accepted on a futur version of your plugin (I used version 1.6)
Regards
Pierre
-
Hi Florian (original creator) and every people,
Thanks to a good idea of a gf I searched a plugin to display a map with location (lat/long) for pictures of my website.
I tested several but your plugin is the better.
But a problem with your plugin was all pictures were already saved with data location.
It was not my case.
I wanted a solution like your plugin but with a module to save data location for every picture on a empty map (from google maps).
Then after some hours to work, i writed this module.
Here are the explanations :
Fields in the TABLE_CONFIG
I added 2 new fields in the TABLE_CONFIG in the script 'histotag_install.php' :
//Last geodata used By Pierre BASMOREAU (28/09/2010)
if (!$CONFIG['plugin_flf_histotag_lastlatitude']) {
$sql = "insert IGNORE into {$CONFIG['TABLE_CONFIG']} values ('plugin_flf_histotag_lastlatitude','0.000000')";
cpg_db_query($sql); }
if (!$CONFIG['plugin_flf_histotag_lastlongitude']) {
$sql = "insert IGNORE into {$CONFIG['TABLE_CONFIG']} values ('plugin_flf_histotag_lastlongitude','0.000000')";
cpg_db_query($sql); }
//End of last geodata
These fields save the last location used after creating geodata of an image.
Script "creategeodata.php"
This new script is placed at the root of your plugin and works only in the admin mode.
This script is based on code of this website : http://itouchmap.com/latlong.html
I cleaned this code to keep the essentiel.
a) For a picture WITHOUT geodata:
It displays an empty map (from Google Maps) just to locate the place of picture (the thumb is displayed under the map).
A submit button saves the current location of the marker into the table "plugin_flf_histotag" (fields : 'exif_GPS_GPSLatitudeRef', 'exif_GPS_GPSLatitude_1', 'exif_GPS_GPS_Latitude_2', 'exif_GPS_GPSLatitude_3', 'exif_GPS_GPSLongitudeRef', 'exif_GPS_GPSLongitude_1', 'exif_GPS_GPS_Longitude_2', 'exif_GPS_GPSLongitude_3').
b) For picture WITH geodata :
The same map is displayed but with the marker located in the lat/long from the picture. So if the location is bad, administrator can change it.
After saving the new location of picture, latitude and longitude are saved in these 2 new fields defined above.
This location is used to start a new location for a next picture near the previous.
Script "include/histotag_support.php":
I done some changes in the functions 'renderGeoButton' and 'GenerateLinkToMap'.
a) First, on function 'GenerateLinkToMap', I wanted that this function returns always a result with difference between 'user mode' and 'admin mode'. The link returned in admin mode is not used.
function GenerateLinkToMap($CoppermineID) {
// Generate a Link to the Google Map for the picture with the given $ID
// 1st read GPS EXIF-Data from Datbase
// IF exists, convert to decimal output for google Maps
// Then generate link to open new map
// New map is being generated with code from map.php
/******************************************************************************
DATE: 28/09/2010 By Pierre BASMOREAU
function returns always a link
******************************************************************************/
global $CONFIG, $flf_lang_var;
$query="select * from {$CONFIG['TABLE_PREFIX']}plugin_flf_histotag where pid='{$CoppermineID}'";
$vResult = cpg_db_query($query);
$array = mysql_fetch_assoc($vResult);
if ($vResult) {
// found data in table 'plugin_flf_histotag'
$lat_hour=flf_calc($array['exif_GPS_GPSLatitude_1']);
$lat_min=flf_calc($array['exif_GPS_GPSLatitude_2']);
$lat_sec=flf_calc($array['exif_GPS_GPSLatitude_3']);
$long_hour=flf_calc($array['exif_GPS_GPSLongitude_1']);
$long_min=flf_calc($array['exif_GPS_GPSLongitude_2']);
$long_sec=flf_calc($array['exif_GPS_GPSLongitude_3']);
// if data are ok calc latitude and longitude
if ($lat_hour && $lat_min && $lat_sec && $long_hour && $long_min && $long_sec) {
$flf_longitude =degree2decimal($long_hour."h".$long_min."m".$long_sec."s".$array['exif_GPS_GPSLongitudeRef']);
$flf_latitude=degree2decimal($lat_hour."h".$lat_min."m".$lat_sec."s".$array['exif_GPS_GPSLatitudeRef']);
$maplink = <<<EOT
plugins/flf_histotag/include/histotag_map.php?width={$CONFIG['plugin_flf_histotag_mapwidth']}&height={$CONFIG['plugin_flf_histotag_mapheight'] }&apiKey={$CONFIG['plugin_flf_histotag_apikey'] }&latitude={$flf_latitude}&longitude={$flf_longitude}&type={$CONFIG['plugin_flf_histotag_mapmode']}&showcontrol={$CONFIG['plugin_flf_histotag_changemaptype']}
EOT;
$returnvalues[0]=$maplink;
$returnvalues[1]=$flf_longitude;
$returnvalues[2]=$flf_latitude;
}
else {
// If admin mode = link on creategeodata.php (29/09/2010)
if (GALLERY_ADMIN_MODE) {
//maplink not used in this state. It is here just to return a value
$maplink = <<<EOT
plugins/flf_histotag/creategeodata.php?width={$CONFIG['plugin_flf_histotag_mapwidth']}&height={$CONFIG['plugin_flf_histotag_mapheight'] }&apiKey={$CONFIG['plugin_flf_histotag_apikey'] }&type={$CONFIG['plugin_flf_histotag_mapmode']}&showcontrol={$CONFIG['plugin_flf_histotag_changemaptype']}
EOT;
$returnvalues[0]=$maplink;
}
}
}
return $returnvalues;
}
b) Second, on function 'renderGeoButton' I wanted display a message on various cases :
- "No geodata for this picture" in user mode;
- "Create geodata for this picture" in admin mode if picture have no geodata;
- "View/Modify geodata" in admin mode when picture have location.
function renderGeoButton($template_img_navbar) {
global $CONFIG, $CURRENT_PIC_DATA, $FAVPICS, $REFERER, $lang_picinfo, $flf_lang_var;
$ref = $REFERER ? "&referer=$REFERER" : '';
switch ($CONFIG['plugin_flf_histotag_mapmode']) {
case '6':
$geo_tgt_return=generateLinkToBingMap($CURRENT_PIC_DATA['pid']);
break;
default:
$geo_tgt_return=generateLinkToGoogleMap($CURRENT_PIC_DATA['pid']);
$geo_tgt=$geo_tgt_return[0].$ref."#top_display_media";
break;
}
// $fav_tgt = "addfav.php?pid={$CURRENT_PIC_DATA['pid']}".$ref."#top_display_media";
/******************************************************************************
DATE: 28/09/2010 By Pierre BASMOREAU
$geo_tgt_return[0] returns always a link (see Function GenerateLinkToMap)
If geodata :
$geo_tgt_return[0] returns a link to show the place on map
$geo_tgt_return[1] et $geo_tgt_return[2] returns long/lat
If no geodata :
$geo_tgt_return[0] returns a link on 'creategeodata.php' only in ADMIN MODE
$geo_tgt_return[1] not exists
******************************************************************************/
// To test if geodata, add a clause $geo_tgt_return[1]
if ($geo_tgt_return[0] && $geo_tgt_return[1]) {
// GeoData found
//User mode ? ===> just show the map
if (!GALLERY_ADMIN_MODE) {
$geo_tgt=$geo_tgt_return[0];
$geo_title = $flf_lang_var['click_link'];
$geo_icon = "geo.png";
$geo_icon_hover = "geo.png";
$geo_button="
<script type=\"text/javascript\" src=\"plugins/flf_histotag/js/greybox_rightsize.js\"></script>
<td align=\"center\" valign=\"middle\" class=\"navmenu\" width=\"42\">
<a href=\"$geo_tgt\" flfwidth=\"{$CONFIG['plugin_flf_histotag_mapboxwidth']}\" flfheight=\"{$CONFIG['plugin_flf_histotag_mapboxheight']}\" class=\"flfbox\" title=\"{$flf_lang_var['notice']}\" id=\"geo_lnk\"><img src=\"plugins/flf_histotag/images/$geo_icon\" border=\"0\" align=\"middle\" alt=\"$geo_title\" id=\"geo_ico\" /></a>
</td>
<script type=\"text/javascript\">
$('#fav_lnk').mouseover(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon_hover'); } );
$('#fav_lnk').mouseout(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon'); } );
</script>
";
}
//Admin mode ? ===>view or modify geodata
else {
$geo_title = $flf_lang_var['view_modify_geodata'];
$geo_icon = "geo.png";
$geo_icon_hover = "geo.png";
$geo_button = "
<script type=\"text/javascript\" src=\"plugins/flf_histotag/js/greybox_rightsize.js\"></script>
<td align=\"center\" valign=\"middle\" class=\"navmenu\" width=\"42\">
<a href=\"javascript:;\" title=\"$geo_title\" onclick=\"return MM_openBrWindow('index.php?file=flf_histotag/creategeodata&id={$CURRENT_PIC_DATA['pid']}&latitude={$geo_tgt_return[2]}&longitude={$geo_tgt_return[1]}','Create GeoData','scrollbar=no,toolbar=no,status=no,resizable=no,width=700,height=500')\"><img src=\"plugins/flf_histotag/images/$geo_icon\" border=\"0\" align=\"middle\" alt=\"$geo_title\" id=\"geo_ico\" /></a>
</td>
<script type=\"text/javascript\">
$('#fav_lnk').mouseover(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon_hover'); } );
$('#fav_lnk').mouseout(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon'); } );
</script>
";
}
}
// Else no geodata
else {
if ($CONFIG['plugin_flf_histotag_geosupport']=='1') {
// if user mode = no link
if (!GALLERY_ADMIN_MODE) {
// show button only if parameter is set, otherwise: no button!
$geo_tgt="#top_display_media";
$geo_title = $flf_lang_var['no_data'];
$geo_icon = "nogeo.png";
$geo_icon_hover = "nogeo.png";
$geo_button = "
<td align=\"center\" valign=\"middle\" class=\"navmenu\" width=\"42\">
<a href=\"$geo_tgt\" class=\"navmenu_pic\" title=\"$geo_title\" id=\"geo_lnk\"><img src=\"plugins/flf_histotag/images/$geo_icon\" border=\"0\" align=\"middle\" alt=\"$geo_title\" id=\"geo_ico\" /></a>
</td>
<script type=\"text/javascript\">
$('#fav_lnk').mouseover(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon_hover'); } );
$('#fav_lnk').mouseout(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon'); } );
</script>
";
}
// if admin mode = show button with link to 'creategeodata.php'
else {
$geo_tgt=$geo_tgt_return[0];
$geo_title = $flf_lang_var['no_data_admin'];
$geo_icon = "nogeo.png";
$geo_icon_hover = "nogeo.png";
$geo_button = "
<script type=\"text/javascript\" src=\"plugins/flf_histotag/js/greybox_rightsize.js\"></script>
<td align=\"center\" valign=\"middle\" class=\"navmenu\" width=\"42\">
<a href=\"javascript:;\" title=\"$geo_title\" onclick=\"return MM_openBrWindow('index.php?file=flf_histotag/creategeodata&id={$CURRENT_PIC_DATA['pid']}','Create GeoData','scrollbar=no,toolbar=no,status=no,resizable=no,width=700,height=500')\"><img src=\"plugins/flf_histotag/images/$geo_icon\" border=\"0\" align=\"middle\" alt=\"$geo_title\" id=\"geo_ico\" /></a>
</td>
<script type=\"text/javascript\">
$('#fav_lnk').mouseover(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon_hover'); } );
$('#fav_lnk').mouseout(function() { $('#fav_ico').attr('src', 'plugins/flf_histotag/images/$geo_icon'); } );
</script>
";
}
}
}
$search = substr_count($template_img_navbar, "<!-- BEGIN pic_info_button -->") > 0 ? "<!-- BEGIN pic_info_button -->" : "<!-- BEGIN slideshow_button -->";
$template_img_navbar = str_replace($search, $geo_button.$search, $template_img_navbar);
return $template_img_navbar;
}
On every case, a particular link is called to view only location or to create/view/modify location by the script "creategeodata.php".
Files "lang/english.php" and "lang/french.php"
I added some messages in english/french to display messages in the correct langue :
// New messages (28/09/2010) By Pierre BASMOREAU
$flf_lang_var['no_data_admin'] = 'Create geodata for this image';
$flf_lang_var['save_geodata'] = 'GeoData saved successfull';
$flf_lang_var['center_marker'] = 'Center marker';
$flf_lang_var['view_modify_geodata'] = 'View/Modify geodata';
$flf_lang_var['submit_geodata'] = 'Tag picture';
// End of new messages
U can test this module on your website.
U can find these files attached here.
I hope my work will be accepted on a futur version of your plugin (I used version 1.6)
Regards
Pierre
-
Hi,
A new version (1.7) of plugin 'flf_histotag' created by Florian is available.
I rewrited my contribution (to create geodata) and i put my new files here to download.
A new image called 'google_maps_logo.png" must be installed in "images" directory of plugin.
Regards, Pierre
-
Hi Pierre, and thanks for your contribution. I'm happy to see those additions. I'll play around with your contributions a little bit and we should then discuss how to include them in the original version. I'll get back to you.
Cheers, Florian
P.S. Could some mod be so kind to move these posts to the plugin thread for flf_histotag? Thx.
-
Hi all.
I experience a problem in reading GPS data from some pictures. I mean that sometimes gps datas are not read from the plugin, returning the no-geotagging button.
Is there any cheat to use to avoid this problem?
Thank you for your answers.
-
Maybe your picture is too big and gets resized by Coppermine. In that case all meta data are lost.
-
I controlled the size, but it was exactly the same of the original file.
I tryed to ftp it in the album folder and batch add it, but it again doesn't give me the GPS data (it can find only those, because other data are correctly got.
Reading gps data with a little php file i did, gets back the right GPS data..........
-
Try to update with the latest svn snapshot as described in the docs:
- http://documentation.coppermine-gallery.net/en/dev_subversion.htm#dev_subversion_download_tarball
- http://documentation.coppermine-gallery.net/en/upgrading.htm#upgrade_any
The resizing method has been optimized. Maybe it works with that development version.
-
But I think that resizing I would lose also other exif data. But the platform correctly reads other exif data....
-
Could some mod be so kind to move these posts to the plugin thread for flf_histotag?
Merged as suggested.
-
I controlled the size, but it was exactly the same of the original file.
I tryed to ftp it in the album folder and batch add it, but it again doesn't give me the GPS data (it can find only those, because other data are correctly got.
Reading gps data with a little php file i did, gets back the right GPS data..........
Hello,
Are you using watermarks?
I had the same problem mit GD2 and watermarks. Now I'm using ImageMagick, and the GPS data are visible.
-
Try to update with the latest svn snapshot as described in the docs:
- http://documentation.coppermine-gallery.net/en/dev_subversion.htm#dev_subversion_download_tarball
- http://documentation.coppermine-gallery.net/en/upgrading.htm#upgrade_any
The resizing method has been optimized. Maybe it works with that development version.
don't works with that development version. if GD watermarks enable .... no geodata are displayed. ???
-
I fixed the problem, that watermarked images lose their exif information. The plugin now checks, if the original file resides in the same folder and if that is the case, it extracts the exifs from this file. This should then also work in case you have automated resizing of images you upload.
Please check version 1.8 (see first post for dl) if you find any additional issues.
Cheers, Florian
-
I fixed the problem, that watermarked images lose their exif information. The plugin now checks, if the original file resides in the same folder and if that is the case, it extracts the exifs from this file. This should then also work in case you have automated resizing of images you upload.
Please check version 1.8 (see first post for dl) if you find any additional issues.
Cheers, Florian
hi florian,
good job. now works correct! beautiful plug-in. :thumbs up:
thank you
ps: you forget to update the version number in new release. new version 1.8 display version 1.7. ;)
-
Finally I fixed the problem.
The exif GPS data are correctly read, but when the function tries to determine if for a picture it must show the "geo is present" or "geo is not present" button, if one of the GPS values is 0 it returns a bad value.
I had to change a line in histotag_support.php, in the function GenerateLinkToMap:
from
if ($lat_hour && $lat_min && $lat_sec && $long_hour && $long_min && $long_sec ) {
to
if ($lat_hour !== false && $lat_min !== false && $lat_sec !== false && $long_hour !== false && $long_min !== false && $long_sec !== false ) {
-
Fixed in v1.9. Thanks. Link is in first post.
Cheers, Florian
-
Hello Florian,
I think, with 1.9 each picture (if there are GPS-values or not) has a Google-Map.
If there are no GPS-values, position is shown as 0/0.
-
you're right. Sorry about that. Fixed - no change in version no.
-
Hello Florian,
Now it looks good ;).
-
but now .... don't display the histogram on any image.
-
but now .... don't display the histogram on any image.
Hello,
In my gallery, there are histogramms available.
-
Hi loungelizard,
Your plugin looks really handy for a project I am working on - thanks very much for all the work you've put in. I noted pbasmo's contribution earlier in the thread, and wonder if you have been able to integrate it into the main codebase? For me it would be very helpful, as the images on my site come from a time before geotagging was possible....
A couple of installation points.
I found it hard to discover where to signup for my API key - there doesn't seem to be a link from the maps api pages to <http://code.google.com/apis/maps/signup.html>, which is I believe the place. Also, my gallery is running happily without create or drop table privs, but the plugin needs them (at least to start with), so it might be worth mentioning that. Having set it up can I now drop those privs again?
Best regards, Ruth
http://images.ivimey.org/
-
Just installed the latest version of this using the upload button in the plugins screen.
I then get this error
Fatal error: require() [function.require]: Failed opening required './plugins/flf_histotag/lang/english.php' (include_path='.:/usr/share/php:/usr/share/pear') in /home/share-snaps/public_html/plugins/flf_histotag/init.inc.php on line 14
and when i log onto my server via ftp, i notice that none of the directorys have been taken out of the zip file.
I have manually extracted them from the zip and uploaded the directorys via ftp and it now works correctly
Is it possible to add coordinates for a picture, and display the images kind of like the plugin that i use for pixelpost on www.fluffysheep.net ?
not sure how this plugin works yet as not got any geotags in images yet, but on my fluffysheep page, i can show a map of the uk (or any where/size specified in the config) with all the places with pictures showing a small picture overlaid on it, and also there is a button to show the current image on a map that shows a section of the map with a copy of that one picture overlaid on it. The pixelpost plugin was just called googlemap i think, and cant remember who wrote it
Dave
-
I did a quick edit of the English lang file to correct a few minor misspellings and other minor English touch-ups.
-
Sorry, I discovered that I used an unescaped apostrophe in line 60. I've corrected that by removing the apostrophe and hav atached the corrected file. My apologies.
-
Hello,
In version 1.5.12 of coppermine the plugin doesn't work.
For images which are already in the galerie, it's ok. But new pictures, have no position-data.
-
Hello,
In version 1.5.12 of coppermine the plugin doesn't work.
For images which are already in the galerie, it's ok. But new pictures, have no position-data.
Hello once again,
Version 1.5.8 was the last version, that the plugin was working (with my gallery).
If I upload an image with position-data, there is no map available for this image.
If I download the original image, the position data are ok.
Has anyone the same problem, or is there a problem in my database?