Advanced search  

News:

cpg1.5.46 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter recently discovered vulnerabilities. It is important that all users who run version cpg1.5.44 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Versioncheck error  (Read 3835 times)

0 Members and 1 Guest are viewing this topic.

lurkalot

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 824
  • +Tinyportal Support team.
Versioncheck error
« on: January 11, 2012, 09:12:44 pm »

Upgraded two of my galleries to 1.5.18, and on both when viewing the versioncheck it gives me the following error, unless I tick the "Do not connect to the online repository" box.

Quote
Template error
Failed to find block 'file_line' (#<!-- BEGIN file_line -->(.*?)<!-- END file_line -->#s) in :

                    <div class="{CSS_CLASS}">
                        <h2>{HEADER_TXT}</h2>
                        <span class="cpg_user_message">{MESSAGE}</span>


                        <br /><br />
                    </div>
Logged
Running SMF 2.0.13  / Tinyportal 1.2, bridged with Coppermine 1.5.34, plus cpmfetch 2.0.0

Αndré

  • Administrator
  • Coppermine addict
  • *****
  • Country: de
  • Offline Offline
  • Gender: Male
  • Posts: 15369
Re: Versioncheck error
« Reply #1 on: January 12, 2012, 08:27:32 am »

Works as expected in my gallery. Please post a link to your gallery and/or try again with the curve theme.
Logged

lurkalot

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 824
  • +Tinyportal Support team.
Re: Versioncheck error
« Reply #2 on: January 12, 2012, 08:57:09 am »

Andre, I'm using the curve theme. ;)  http://cctestsite.info/gallery/  You should still have a admin login, should you need to use it.
Logged
Running SMF 2.0.13  / Tinyportal 1.2, bridged with Coppermine 1.5.34, plus cpmfetch 2.0.0

Αndré

  • Administrator
  • Coppermine addict
  • *****
  • Country: de
  • Offline Offline
  • Gender: Male
  • Posts: 15369
Re: Versioncheck error
« Reply #3 on: January 12, 2012, 10:30:40 am »

The block "file_line" is a part of that variable:
Code: [Select]
/******************************************************************************
** Section <<<$template_cpg_die>>> - START
******************************************************************************/
// HTML template used by the cpg_die function
$template_cpg_die = <<<EOT
                    <div class="{CSS_CLASS}">
                        <h2>{HEADER_TXT}</h2>
                        <span class="cpg_user_message">{MESSAGE}</span>
<!-- BEGIN file_line -->
                        <br />
                        <br />
                        {FILE_TXT}{FILE} - {LINE_TXT}{LINE}
<!-- END file_line -->
<!-- BEGIN output_buffer -->
                        <br />
                        <br />
                        <div align="left">
                                {OUTPUT_BUFFER}
                        </div>
<!-- END output_buffer -->
                        <br /><br />
                    </div>

EOT;
/******************************************************************************
** Section <<<$template_cpg_die>>> - END
******************************************************************************/

As you can see it's a part of the cpg_die function. Unfortunately I wasn't able to find it in that context. Curiously enough, cpg_die works as expected at other places.

When enabling debug mode for everyone we see a different error message:
Quote
Template error
Failed to find block 'output_buffer' (#<!-- BEGIN output_buffer -->(.*?)<!-- END output_buffer -->#s) in :

                    <div class="{CSS_CLASS}">
                        <h2>{HEADER_TXT}</h2>
                        <span class="cpg_user_message">{MESSAGE}</span>
<!-- BEGIN file_line -->
                        <br />
                        <br />
                        {FILE_TXT}{FILE} - {LINE_TXT}{LINE}
<!-- END file_line -->

                        <br /><br />
                    </div>


I'd need FTP access to your gallery to debug that error message as I have absolutely no clue what's happening there.
Logged

lurkalot

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 824
  • +Tinyportal Support team.
Re: Versioncheck error
« Reply #4 on: January 12, 2012, 10:36:01 am »

Thanks Andre, I'll send you a PM. ;)
Logged
Running SMF 2.0.13  / Tinyportal 1.2, bridged with Coppermine 1.5.34, plus cpmfetch 2.0.0

Αndré

  • Administrator
  • Coppermine addict
  • *****
  • Country: de
  • Offline Offline
  • Gender: Male
  • Posts: 15369
Re: Versioncheck error
« Reply #5 on: January 12, 2012, 12:10:25 pm »

Small update.

There's no error before the following line in versioncheck.php:
Code: [Select]
pageheader($lang_versioncheck_php['title']);
Function pageheader generates no error if you comment out
Code: [Select]
'{MESSAGE_BLOCK}' => theme_display_message_block(),and let it die before
Code: [Select]
adminmessages();
If you comment out/remove adminmessages() or abort pageheader with a return before that line you get the error message again. Maybe I miss the forest for the trees, but that makes absolutely no sense.

If I comment out everything from
Code: [Select]
$template_varsin the pageheader function, it doesn't return an error, but another line in versioncheck.php does ::)

It took me one and a half hour to get that result. As I think it's an individual issue I don't want to spend more time on that issue until someone else reports the same behavior. As I said, it works as expected in my gallery. Maybe someone else can confirm that, too.
Logged

Αndré

  • Administrator
  • Coppermine addict
  • *****
  • Country: de
  • Offline Offline
  • Gender: Male
  • Posts: 15369
Re: Versioncheck error
« Reply #6 on: January 12, 2012, 12:22:03 pm »

The only benefit to connect to the online repository is that you'll be noticed of a new major version. If you've installed the latest version the source files are identical and you're fine to check "Do not connect to the online repository".
Logged

lurkalot

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 824
  • +Tinyportal Support team.
Re: Re: Versioncheck error
« Reply #7 on: January 12, 2012, 06:35:52 pm »


As I think it's an individual issue I don't want to spend more time on that issue until someone else reports the same behavior. As I said, it works as expected in my gallery. Maybe someone else can confirm that, too.


Thanks for looking into this issue.  I agree it's only me having the problem so far, but it's happened on two different sites for me.  ;)

The only benefit to connect to the online repository is that you'll be noticed of a new major version. If you've installed the latest version the source files are identical and you're fine to check "Do not connect to the online repository".

Absolutely, I'm fine with it as is, just wanted to point out my findings after upgrading.  Thanks again. ;)
Logged
Running SMF 2.0.13  / Tinyportal 1.2, bridged with Coppermine 1.5.34, plus cpmfetch 2.0.0

AntonLargiader

  • Coppermine novice
  • *
  • Country: 00
  • Offline Offline
  • Posts: 31
    • My Coppermine Album
Re: Versioncheck error
« Reply #8 on: May 13, 2012, 03:04:39 pm »

I found a similar result when I just used versioncheck. This was with "Show warnings only" and "Don't check for modified files".  It subsequently worked properly with no filters, and then worked properly with the same filters. I happened to still have this in my clipboard when I found this thread...

Code: [Select]
Template error
Failed to find block 'output_buffer' (#<!-- BEGIN output_buffer -->(.*?)<!-- END output_buffer -->#s) in :

                    <div class="{CSS_CLASS}">
                        <h2>{HEADER_TXT}</h2>
                        <span class="cpg_user_message">{MESSAGE}</span>
<!-- BEGIN file_line -->
                        <br />
                        <br />
                        {FILE_TXT}{FILE} - {LINE_TXT}{LINE}
<!-- END file_line -->

                        <br /><br />
                    </div>
Logged
My album:  www dot largiader dot com slash album
Pages: [1]   Go Up
 

Page created in 0.02 seconds with 21 queries.