Advanced search  

News:

cpg1.5.46 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter recently discovered vulnerabilities. It is important that all users who run version cpg1.5.44 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: [Fixed]: Missing Closing H2 Tag Possibly Renders Update Output Unreadable  (Read 2958 times)

0 Members and 1 Guest are viewing this topic.

onthepike

  • Guest

Regarding this thread: Need Help Changing Theme

I was able to reproduce and provide an example of the update.php output rendering white text against the default grey table data background cell. See link above for details and visual examples attached below.

In searching for an explanation, I happened across an unclosed h2 tag in update.php (Revision: 7613):

Code: [Select]
   // Update table prefix
    $sql_query = preg_replace('/CPG_/', $CONFIG['TABLE_PREFIX'], $sql_query);

    $sql_query = remove_remarks($sql_query);
    $sql_query = split_sql_file($sql_query, ';');

    ?>
        <h2>Performing Database Updates<h2>
        <table class="maintable">

Changing the line

Code: [Select]
<h2>Performing Database Updates<h2> to (obviously)
Code: [Select]
<h2>Performing Database Updates</h2>

Resulted in my no longer having the ability to duplicate the issue. Therefore, I am going to attribute this intermittent error (which is most likely browser-setting respective, since it's not visible in all applications) to the open tag if and until the issue presents itself once again.

I hope I have not over-stepped by posting here. There didn't seem a more appropriate board within 1.4 Support since this issue does deal specifically with a typo in an html tag.

Also, while this issue would generally be considered cosmetic in nature, it is apparently easily solved by closing an html tag.

Thank you for your time.

Jeff
« Last Edit: June 17, 2010, 10:30:12 am by Αndré »
Logged

Αndré

  • Administrator
  • Coppermine addict
  • *****
  • Country: de
  • Offline Offline
  • Gender: Male
  • Posts: 15428
Re: Missing Closing H2 Tag Possibly Renders Update Output Unreadable
« Reply #1 on: June 17, 2010, 10:29:52 am »

Fixed in r7693.
Logged
Pages: [1]   Go Up
 

Page created in 0.013 seconds with 21 queries.