Advanced search  

News:

cpg1.5.46 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter recently discovered vulnerabilities. It is important that all users who run version cpg1.5.44 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: New GoogleMaps plugin for Coppermine v1.5  (Read 12669 times)

0 Members and 1 Guest are viewing this topic.

Sapman

  • Coppermine newbie
  • Offline Offline
  • Posts: 4
New GoogleMaps plugin for Coppermine v1.5
« on: May 22, 2010, 09:03:15 pm »

Hi everybody!

Recently I developed new plugin to integrate Google Maps window into Coppermine PicInfo section. Now I like to share my experience with others.

Plugin currently supports 2 languages - Russian and English.  No configuration requied to install, no code modification needed. Also forget about GoogleMaps site keys.

How to use:

1. Install like any other plugin. When installed, plugin adds row 'Geotags' in PicInfo section.

2. Open picture with geotags. Row 'Geotags' should have a hyperlink with Longitude and Latitude from image.

3. Click on hyperlink. GoogleMaps window expands below.

Sample album with geocoded photos and plugin installed -
http://www.anyphoto.ru/displayimage.php?album=3&pid=4#top_display_media

Plugin can be downloaded from here - http://anyphoto.ru/GoogleMaps(Coppermine_v1.5).rar

P.S. I hope somebody will tell me, how my plugin can be registered with others for Coppermine 1.5 on SourceForge. 
Logged

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4455
    • Windsurf.me
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #1 on: May 22, 2010, 11:07:10 pm »

Good work but still needs a little more to make it really good.

Instead of hard coding the languages in codebase it is better to use a variable and a language file. At the moment adding languages could result in a right mess.

A good example of how this should be done can be found by looking at the following plugins code - http://forum.coppermine-gallery.net/index.php/topic,64820.0.html

Keep up the good work. I'm sure Joachim will add this to the repositry on soundforge. I'm not sure I know or have the relavent permissions to do so.
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #2 on: May 23, 2010, 12:37:51 am »

Well done - keep on improving your plugin; I have cleaned it up a little in terms of standards compliance, naming scheme and indentation. Please base your improvements on the version I attached.

Cheers

Joachim
Logged

Sapman

  • Coppermine newbie
  • Offline Offline
  • Posts: 4
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #3 on: May 24, 2010, 07:10:01 pm »

Good work but still needs a little more to make it really good.

Instead of hard coding the languages in codebase it is better to use a variable and a language file. At the moment adding languages could result in a right mess.

A good example of how this should be done can be found by looking at the following plugins code - http://forum.coppermine-gallery.net/index.php/topic,64820.0.html

Keep up the good work. I'm sure Joachim will add this to the repositry on soundforge. I'm not sure I know or have the relavent permissions to do so.

Plugin Updated (multilanguage support added in separate files.) Everything ok now?
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #4 on: May 25, 2010, 07:38:09 am »

Hm, no. It's a pity that you haven't done as I suggested:
Please base your improvements on the version I attached.
, but in fact you did quite the opposite. As I suggested, I have spent quite some time to correct several flaws in your initial release. Wasting all those changes by ignoring my advice is not a bright idea, or at least not nice. Please read up the documentation's sections that explain naming schemes, i18n and coding standards. Naming your variables "bla_bla" and so on is not helpful and not something we're fond of, sorry.
Logged

Sapman

  • Coppermine newbie
  • Offline Offline
  • Posts: 4
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #5 on: May 25, 2010, 06:37:39 pm »

Joachim,

I'm not sure I have enough time to read all sections of developers info. I had an idea to write this plugin and share it to other end-users, not coders. End-users not interested in code exellence - they need functionality and reliability. 


To coders: anybody can change my plugin to satisfy Joachim's rules, just put it in repository for end-user convenience.

Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #6 on: May 26, 2010, 07:58:15 am »

Being too lazy to read the docs is one thing. Ignoring the effort I have put into improving your plugin is another thing. There's no added functionality in the attachment in Sapman's second attachment in this thread, so please don't use it. Additionally, the changes I applied are not only cosmetical, but they serve a purpose, as there is a reason behind the policies that is not only beauty and readability of code, but practical reasons. It's for example a bad idea to use capitalization in folder names, as this will work in some cases (i.e. on some webserver setups) and won't work on others. Reacting in the way you did seems a bit stubborn and selfish to me...
I have added i18n and cleaned the plugin up even more - changes went into the attached file. Anyone who wishes to further improve the plugin, please use that version.
I wasn't able to actually test the plugin, as I don't have geocoded images I could test with.

Joachim

P.S. The demo image you refered to above in your initial posting no longer exists, that's a pity.
« Last Edit: May 26, 2010, 09:57:32 am by Joachim Müller »
Logged

Sapman

  • Coppermine newbie
  • Offline Offline
  • Posts: 4
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #7 on: June 04, 2010, 01:31:43 pm »

Logged

mykee

  • Contributor
  • Coppermine frequent poster
  • ***
  • Country: hu
  • Offline Offline
  • Gender: Male
  • Posts: 140
    • One moment from Hungary
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #8 on: June 05, 2010, 11:53:53 am »

I get this error when click a picture:
Fatal error: Call to undefined function read_exif_data_raw() in /plugins/google_maps/codebase.php on line 24

I have installed Jsmin, Flash Media Player, Who is online, Filetypes editor, Keyboard navigation plugins.
Link is here, try a foto:
http://foto.acegem.hu/index.php
Logged
My gallery and demo for AnythingSlider, Photocols and CollagePlus plugin: http://foto.acegem.hu/index.php

mykee

  • Contributor
  • Coppermine frequent poster
  • ***
  • Country: hu
  • Offline Offline
  • Gender: Male
  • Posts: 140
    • One moment from Hungary
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #9 on: June 05, 2010, 12:21:23 pm »

Ok, I deactivated this plugin while not working.  :-\
Logged
My gallery and demo for AnythingSlider, Photocols and CollagePlus plugin: http://foto.acegem.hu/index.php

mazze

  • Coppermine newbie
  • Offline Offline
  • Posts: 1
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #10 on: June 09, 2010, 01:08:54 pm »

i used CP 1.5.6 and the plugin cpg1.5.x_plugin_google-maps_v1.2
when i click on a photo there is an error: Fatal error: Call to undefined function read_exif_data_raw() in /web/x/xxx/xxxxx/xx/htdocs/cp/plugins/google_maps/codebase.php  on line 24
i have PHP Version 5.2.13 and EXIF Support is enabled...
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Logged

sjat

  • Coppermine newbie
  • Offline Offline
  • Posts: 1
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #12 on: January 16, 2012, 11:47:15 pm »

Can anybody help me:
How can I remove the EXIF output in the top of the screen, when I am using this plugin ?
Link: http://yksi.dk/test/displayimage.php?pid=1#top_display_media

Its only a testsite with that one photo, but the problem is the same at my real site...
Thanks in advance
Sjat
Logged

cavok

  • Coppermine regular visitor
  • **
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 93
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #13 on: April 20, 2013, 08:54:37 pm »

Hello,
I have some position errors on the map with this plugin v1.2.
Where is West longitude, the position is show on the map as East.
It seems he does not make a distinction between West and East, and that makes every East.
When I display a East Longitude position, there is no error.
All this with a North Latitude, I have nothing in South to try if the error Repette in Latitude.
Do you have the same errors ?
Would you solutions to fix this problem ?
Thank you for your help
Logged
Coppermine 1.5.22 hosting by Free

Ruhrpottjung

  • Coppermine newbie
  • Offline Offline
  • Posts: 1
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #14 on: July 22, 2013, 01:58:56 am »

I'm sorry but it don't work at me only get a error when I click on a picture:

Quote
Fatal error: Call to undefined function read_exif_data_raw()

Maybe can be fixed?

Thnx
Hans
Logged

cmfa

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Posts: 226
Re: New GoogleMaps plugin for Coppermine v1.5
« Reply #15 on: August 03, 2013, 06:11:39 pm »

The error message is ok, because there is no longer this function. In the appendix the codebase.php with another function. So it should work again.

cmfa
Logged
Pages: [1]   Go Up
 

Page created in 0.026 seconds with 21 queries.