Advanced search  

News:

cpg1.5.46 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter recently discovered vulnerabilities. It is important that all users who run version cpg1.5.44 or older update to this latest version as soon as possible.
[more]

Pages: 1 2 3 4 [5] 6 7 8 9 10   Go Down

Author Topic: EnlargeIt! AJAX GUI for CPG 1.5.x  (Read 122193 times)

0 Members and 1 Guest are viewing this topic.

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #80 on: December 05, 2009, 09:08:59 am »

Timo had sent me an admin account for his testbed, where I was able to replicate his issues: the changes on the config screen just wouldn't stick. I changed some things around that I thought were not related, but that seems to have done the trick, so the issue didn't lie on Timo's end, but on mine. Sorry for wasting your time. Anyway, v1.7 of the plugin should work as expected now (hopefully). On your tesbed I haven't been able to make the plugin work with the slider plugin, so I turned that off temporarily (sorry). Something that has been on my mind is the flash support: I think that it's broken. Maybe you could look into that first? Thanks in advance.

Joachim
Logged

Timos-Welt

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 800
    • Timos-Welt
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #81 on: December 05, 2009, 09:45:08 am »

Hi Joachim,

the problem is still there - saving my settings once, all file types get de-activated.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #82 on: December 05, 2009, 10:55:44 pm »

That's indeed weird. I could have sworn that it sticked when I tested some hours ago. Please uncomment
Code: [Select]
//print_r($superCage->post->getRaw($san_key));in plugins/enlargeit/codebase.php
Logged

Timos-Welt

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 800
    • Timos-Welt
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #83 on: December 08, 2009, 05:49:32 pm »

That's indeed weird. I could have sworn that it sticked when I tested some hours ago. Please uncomment
Code: [Select]
//print_r($superCage->post->getRaw($san_key));in plugins/enlargeit/codebase.php

Done (on admin.php).
Logged

Timos-Welt

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 800
    • Timos-Welt
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #84 on: December 11, 2009, 02:02:48 pm »

Any news regarding the filetype problem? With the latest SVN, I still cannot save my settings. This makes testing really difficult.
Logged

Αndré

  • Administrator
  • Coppermine addict
  • *****
  • Country: de
  • Offline Offline
  • Gender: Male
  • Posts: 15369
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #85 on: December 11, 2009, 02:45:56 pm »

Please install a clean cpg and test your plugin again, as it works for Joachim and works for me, too.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #86 on: December 11, 2009, 03:50:25 pm »

I'm stumped as well that it doesn't work for you. Maybe you could go through the lines 129 to 149 in admin.php: this is where the code resides at that determines what has been set for the multiple select fields in the form and subsequently what get's written to the config.
Logged

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4454
    • Windsurf.me
[Solved]: Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #87 on: December 11, 2009, 04:05:27 pm »

It works fine for me too. What os are you using?
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Timos-Welt

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 800
    • Timos-Welt
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #88 on: December 11, 2009, 04:47:53 pm »

Found the bug. There was a non-standard cr/lf in the file that eliminated one important line. See screen shot.

I committed the fix to the SVN. Now it works!
Logged

Timos-Welt

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 800
    • Timos-Welt
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #89 on: December 11, 2009, 04:58:17 pm »

Added version 1.7 to first post of this thread.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #90 on: December 11, 2009, 05:38:37 pm »

Thanks for the fix.

Always count the version up when fixing bugs. My version has been 1.7, so yours possibly can't be 1.7 as well, but needs to be 1.8, as it differs from my version. I'm currently busy fixing some other issues, so I'll commit in no time. I'll correct the confusing version glitch.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #91 on: December 14, 2009, 10:19:15 am »

Version 1.9 of the plugin is out (attached to initial posting), where I have started a documentation file. All devs are encouraged to populate the browser compatibility chart in that documentation as well as all other possible sections of that file. It's of course a work in progress that will be populated pretty soon.
When reviewing the credits section I wondered what of the ImageFlow code went into the plugin (if any): if part of Finn Rudolph's code has gone into the EnlargeIt plugin it subsequently mustn't be released under GNU GPL, as Finn's license is not compatible at all with that the GPL. Timo, please clarify.

Joachim
Logged

Timos-Welt

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 800
    • Timos-Welt
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #92 on: December 14, 2009, 12:19:08 pm »

EnlargeIt! for cpg1.5.x does not contain any code of Imageflow. For  some time, the 1.4.x version included a dedicated Imageflow plugin version, that's why there was this credit.

BTW: Finn Rudolph stated, that all Imageflow versions prior to 1.0 are still absolutely free to use.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #93 on: December 14, 2009, 12:50:06 pm »

Should the ImageFlow credits be removed from the cpg1.5.x-plugin then?
Logged

Timos-Welt

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 800
    • Timos-Welt
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #94 on: December 14, 2009, 03:55:54 pm »

Yes
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #95 on: December 18, 2009, 10:31:49 am »

The most recent version (as usual) resides in the subversion repository. Reference to ImageFlow has been removed from the credits section. The documentation should answers most questions - do you have any suggestions for it? Anyone care to improve the translations / language files? If you feel like it, you ("you" as "you, the reader of this thread") could as well translate the documentation - that would be cool...
I have started to port the new features from the cpg1.4.x plugin by adding the shadow color feature; I'd really like to start adding all the other options as well, so I'd love to hear your thoughts on my previous posting:
Compared to the plugin for cpg1.4.x, the following features are missing as far as I can see:
  • Use hourglass mouse cursors if browser supports it
  • Shadow color
  • Vote button
  • Comment button
  • Ecard button
  • SEF_URL support
The first two don't look to complicated to implement, as the tricky stuff already has been accomplished by Timo: creating the corresponding functionality in JavaScript. All that needs to be done as far as I can see is porting those functions over to cpg1.5.x ;)
For the other features Timo has implemented files of his own that mimmick the functionality of coppermine's core code. Before I start working on them I suggest to hear Timo's ideas first (wether he's going to implement them or if he prefers this to be done by someone else).
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #96 on: January 18, 2010, 11:59:09 am »

Feature request: currently when mousewheel navigation is enabled a scroll-down with the mouse wheel sends you to the previous image; a scroll-up sends you to the next. This is the opposite of what I find natural. Could this be changed in the future or is there an impact that I'm not aware of?
Logged

Αndré

  • Administrator
  • Coppermine addict
  • *****
  • Country: de
  • Offline Offline
  • Gender: Male
  • Posts: 15369
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #97 on: January 18, 2010, 12:31:48 pm »

I support Joachim's request, as previously mentioned in the stripwheel plugin thread:
I suggest to switch the mousewheel up/down actions:
- scroll up = prev pic
- scroll down = next pic

because it's more intuitive imo and fits better for themes with a vertical filmstrip (e.g. http://gfyoung.homeip.net/cpg15x/displayimage.php?album=1&pid=8#top_display_media).
Logged

Timos-Welt

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 800
    • Timos-Welt
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #98 on: January 18, 2010, 01:48:47 pm »

Should be no problem. In enlargeit_source.js find

Code: [Select]
    if (enl_wheeldelta > 0) enl_next(enl_infront,0);
    if (enl_wheeldelta < 0) enl_next(enl_infront,1);

and change to

Code: [Select]
    if (enl_wheeldelta < 0) enl_next(enl_infront,0);
    if (enl_wheeldelta > 0) enl_next(enl_infront,1);

The direction was chosen after asking my wife how she would like it. She uses an image viewer on her PC that has the same direction in use, so I coded it this way round.
Logged

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4454
    • Windsurf.me
Re: EnlargeIt! AJAX GUI for CPG 1.5.x
« Reply #99 on: February 09, 2010, 05:32:59 pm »

Not sure if this is a bug or just something to do with the way I have upgraded but.

Take a look at the videos here.

http://www.windsurf.me.uk/cpg133/thumbnails.php?album=13

If I disable enlargeit they play fine but with enlargeit enabled I get a media not found error.
Logged
It is a mistake to think you can solve any major problems just with potatoes.
Pages: 1 2 3 4 [5] 6 7 8 9 10   Go Up
 

Page created in 0.023 seconds with 21 queries.