Advanced search  

News:

cpg1.5.46 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter recently discovered vulnerabilities. It is important that all users who run version cpg1.5.44 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: [Fixed]: [cpg1.5.x]: meta name="keywords" & link rel="start" are on the same line  (Read 23820 times)

0 Members and 1 Guest are viewing this topic.

Makc666

  • Translator
  • Coppermine addict
  • **
  • Offline Offline
  • Gender: Male
  • Posts: 1607
  • Русский (ISO-8859-1) - Russian - (Windows)
    • Makc's home page

If you will open this page:
http://coppermine-gallery.net/demo/cpg14x/displayimage.php?album=29&pos=1&displayimage_php?album=29&lang=english

You can see this line in HTML code:
Code: [Select]
<meta name="keywords" content="ArtitstWantedCompetition2006"/><link rel="start" href="displayimage.php?album=29&amp;pos=0" title="Return to start" />
But it seems to me it must look like:
Code: [Select]
<meta name="keywords" content="ArtitstWantedCompetition2006"/>
<link rel="start" href="displayimage.php?album=29&amp;pos=0" title="Return to start" />

To fix this one...

Open:
include/themes.inc.php

Find:
Code: [Select]
       $meta_nav .= "<link rel=\"start\" href=\"$start_tgt\" title=\"$start_title\" />
        ";

Replace with:
Code: [Select]
       $meta_nav .= "
<link rel=\"start\" href=\"$start_tgt\" title=\"$start_title\" />
";

The second line and third one must start from the beginning of the line!

Find:
Code: [Select]
       $meta_nav .= "<link rel=\"last\" href=\"$end_tgt\" title=\"$end_title\" />
        ";

Replace with:
Code: [Select]
       $meta_nav .= "<link rel=\"last\" href=\"$end_tgt\" title=\"$end_title\" />
";

The second line must start from the beginning of the line!

Find:
Code: [Select]
                               $meta_nav .= "<link rel=\"prev\" href=\"$prev_tgt\" title=\"$prev_title\" />
                                ";

Replace with:
Code: [Select]
       $meta_nav .= "<link rel=\"prev\" href=\"$prev_tgt\" title=\"$prev_title\" />
";

The second line must start from the beginning of the line!

Find:
Code: [Select]
                               $meta_nav .= "<link rel=\"next\" href=\"$next_tgt\" title=\"$next_title\"/>
                                ";

Replace with:
Code: [Select]
       $meta_nav .= "<link rel=\"next\" href=\"$next_tgt\" title=\"$next_title\"/>
";

The second line must start from the beginning of the line!

Find:
Code: [Select]
       $meta_nav .= "<link rel=\"up\" href=\"$thumb_tgt\" title=\"".$lang_img_nav_bar['thumb_title']."\"/>
        ";

Replace with:
Code: [Select]
       $meta_nav .= "<link rel=\"up\" href=\"$thumb_tgt\" title=\"".$lang_img_nav_bar['thumb_title']."\"/>";
« Last Edit: May 24, 2009, 01:49:03 PM by Joachim Mller »
Logged

Makc666

  • Translator
  • Coppermine addict
  • **
  • Offline Offline
  • Gender: Male
  • Posts: 1607
  • Русский (ISO-8859-1) - Russian - (Windows)
    • Makc's home page
Re: meta name="keywords" & link rel="start" are on the same line
« Reply #1 on: December 02, 2008, 12:22:49 PM »

After all changes you will have smth like this:

Code: [Select]
<meta name="keywords" content="test1,test2"/>
<link rel="start" href="displayimage-1-0.html" title="Return to start" />
<link rel="last" href="displayimage-1-8.html" title="Skip to end" />
<link rel="next" href="displayimage-1-1.html" title="See next file"/>
<link rel="up" href="thumbnails-1-page-1.html" title="Return to the thumbnail page"/>
<link rel="stylesheet" href="themes/classic/style.css" type="text/css" />

And not this one:
Code: [Select]
<meta name="keywords" content="test1,test2"/><link rel="start" href="displayimage-1-0.html" title="Return to start" />
        <link rel="last" href="displayimage-1-8.html" title="Skip to end" />
        <link rel="next" href="displayimage-1-1.html" title="See next file"/>
                                <link rel="up" href="thumbnails-1-page-1.html" title="Return to the thumbnail page"/>
       
<link rel="stylesheet" href="themes/classic/style.css" type="text/css" />
Logged

Nibbler

  • Guest
Re: meta name="keywords" & link rel="start" are on the same line
« Reply #2 on: December 23, 2008, 08:04:14 PM »

Already done for 1.5 apparently.
Logged

Joachim Mller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de

Not sure who quacked the strange extra spaces into the code that don't make sense at all. Anyway, went through include/themes.inc.php in the SVN repository for cpg1.4.x (revision 5981) and added a proper line break (not the code suggested in this thread though). Applied the fix for themes/sample/theme.php as well.
Change will go into cpg1.4.24.
Marking as "fixed" and moving accordingly.
Logged
Pages: [1]   Go Up
 

Page created in 0.069 seconds with 20 queries.