Advanced search  

News:

cpg1.5.46 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter recently discovered vulnerabilities. It is important that all users who run version cpg1.5.44 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: [Fixed]: Album list empty ablum cell glitch  (Read 9113 times)

0 Members and 1 Guest are viewing this topic.

Matt Carlson

  • Coppermine newbie
  • Offline Offline
  • Posts: 10
    • CarlsonPhotos
[Fixed]: Album list empty ablum cell glitch
« on: March 26, 2008, 07:53:56 pm »

IU noticed a glitch in the way Coppermine displays the album list. For empty cells it takes the spacer.gif and gives it a height equal to the setting for “Size of thumbnails in pixels”. So if size of thumbnails in pixels is set at 120 and the only albums in that row are in landscape format (something like 4:3 format), the result will be extra space in the filled albums. Should not the empty cell just leave the spacer image at something like 1px for height and width?

My testing gallery
http://www.cornlines.com/gallery/
« Last Edit: April 28, 2008, 08:00:36 am by Joachim Müller »
Logged

Matt Carlson

  • Coppermine newbie
  • Offline Offline
  • Posts: 10
    • CarlsonPhotos
Re: Album list empty ablum cell glitch
« Reply #1 on: April 27, 2008, 12:24:09 am »

Solved / Fixed


Coppermine 1.4.19  - theme.inc.php - revison 4392

Line 465

Code: [Select]
<div class="thumbnails" style="background-color:transparent"><img src="images/spacer.gif" width="1" height="{SPACER}" border="0" class="image" style="border:0;margin-top:1px;margin-bottom:0" alt="" /></div>

Replace "{SPACER}" with a "1"

Now so as to keep the peace and follow instructions by developers one should not mess with the theme.inc.php but rather insert the code your own theme.php file as the section for "HTML template for the album list".
Logged

Matt Carlson

  • Coppermine newbie
  • Offline Offline
  • Posts: 10
    • CarlsonPhotos
Re: Album list empty ablum cell glitch
« Reply #2 on: April 27, 2008, 12:38:01 am »

A screenshot of the issue before the change and after.
Logged

Matt Carlson

  • Coppermine newbie
  • Offline Offline
  • Posts: 10
    • CarlsonPhotos
Re: Album list empty ablum cell glitch
« Reply #3 on: April 27, 2008, 12:40:47 am »

PS. Same issue exisits in the under-devolpement 1.5x version.

PPS. I wish there was a way to edit posts here - that or I am missing how to do so.  :-[
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Album list empty ablum cell glitch
« Reply #4 on: April 28, 2008, 08:00:16 am »

Thanks for your report. The issue exists inside the definitions for $template_album_list_cat and $template_album_list. I have applied your suggested changes in the subversion repository both for cpg1.4.x as well as cpg1.5.x. This means that the fix will go into cpg1.4.19 and cpg1.5.0.

PPS. I wish there was a way to edit posts here - that or I am missing how to do so.  :-[
You can't edit your postings due to abuse in the past. It's OK to reply with clarifications as you did.
Logged
Pages: [1]   Go Up
 

Page created in 0.021 seconds with 19 queries.