Advanced search  

News:

cpg1.5.46 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter recently discovered vulnerabilities. It is important that all users who run version cpg1.5.44 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: BUG/fault themes.inc.php ???  (Read 5102 times)

0 Members and 1 Guest are viewing this topic.

mainpower

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 30
    • Photo album of ... (with CPG)
BUG/fault themes.inc.php ???
« on: June 22, 2006, 08:28:59 pm »

Hello,

If I check the HTML code there are 2 times <b><b> ... therefor I change the following line in themes.inc.php (version 1.4.8 );

<span class="statlink"><b>{STATISTICS}</b></span>

into

<span class="statlink">{STATISTICS}</span>

I guess it's a bug/fault ..... but not sure.

Cheers,
Matthijs  ;D
« Last Edit: June 26, 2006, 04:22:48 am by Paver »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: BUG/fault themes.inc.php ???
« Reply #1 on: June 23, 2006, 08:09:26 am »

Cosmetical issue, not an actual bug imo. Anyway, moving accordingly...
Logged

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1608
  • Paul Van Rompay
Re: BUG/fault themes.inc.php ???
« Reply #2 on: June 23, 2006, 02:55:22 pm »

I noticed this a while ago and forgot about it.  I'm not sure if I posted about it.

In any case, my thought is that the bold tags should be in the $template variable since that's display and moved out of the $statistics content.  I'll take a look and see if this makes sense.

edit: Nope, it doesn't make sense.  The statistics content is created from a language variable that puts the bold tags in where it likes.  So the original fix is the correct one.
Logged

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1608
  • Paul Van Rompay
Re: BUG/fault themes.inc.php ???
« Reply #3 on: June 23, 2006, 03:06:30 pm »

Fix committed to devel.  I assume it should not be committed to stable since it's only a cosmetic fix?

edit: Oh, I already committed the changes to stable.  I noticed some other cosmetic fixes from May were committed, so is this OK?
« Last Edit: June 23, 2006, 03:12:54 pm by Paver »
Logged

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1608
  • Paul Van Rompay
Re: BUG/fault themes.inc.php ???
« Reply #4 on: June 26, 2006, 04:25:39 am »

Seems harmless to leave in stable.  Yes, some people may notice that their stats line is no longer all bold.  They can change it if desired in style.css (style 'statlink').

Thread marked as fixed.
Logged
Pages: [1]   Go Up
 

Page created in 0.013 seconds with 20 queries.