Advanced search  

News:

cpg1.5.46 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter recently discovered vulnerabilities. It is important that all users who run version cpg1.5.44 or older update to this latest version as soon as possible.
[more]

Pages: [1] 2 3   Go Down

Author Topic: Oranje theme  (Read 55915 times)

0 Members and 1 Guest are viewing this topic.

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 6006
Oranje theme
« on: February 04, 2006, 02:00:10 pm »

live demo http://stramm.st.funpic.org

the theme is made for my modpack (http://forum.coppermine-gallery.net/index.php?topic=24341.0) but with a few little modifications a standard CPG 1.4 will run it too

« Last Edit: February 08, 2006, 02:47:07 pm by Stramm »
Logged
my CPG sandbox: Version 1.4.18 with modpack running my Tentacle theme:
http://stramm.st.funpic.org/

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Oranje theme
« Reply #1 on: February 04, 2006, 03:57:34 pm »

@all: warning - as Stramm suggested, this theme can not be used as it is for a "regular" coppermine install, it's mandatory to have Stramm's modpack installed to make it work!

@Stramm: nice theme - could you release a version of the theme as well that actually will work with an unmodded coppermine install? It'd be a nice example of a right-handed menu for the demo.
Logged

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 6006
Re: Oranje theme
« Reply #2 on: February 04, 2006, 05:06:53 pm »

@Stramm: nice theme - could you release a version of the theme as well that actually will work with an unmodded coppermine install? It'd be a nice example of a right-handed menu for the demo.

of course... as said, just a few little modifications. Still it looks lots better when using the modpack  ;D
« Last Edit: February 08, 2006, 02:47:52 pm by Stramm »
Logged
my CPG sandbox: Version 1.4.18 with modpack running my Tentacle theme:
http://stramm.st.funpic.org/

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Oranje theme
« Reply #3 on: February 06, 2006, 12:38:45 am »

Thanks for posting your modified version. It looks fine, but there are some serious flaws in it - it is far from cpg1.4.x compliant. I have modified it a bit to show at least the most important new features. However, there are still some design drawbacks (most importantly not respecting the sys_menu/sub_menu structure introduced in cpg1.4.x. In fact, the theme is a cpg1.3.x theme that is made to work with cpg1.4.x some way or the other, however it is not an actual cpg1.4.x theme, as it wasn't upgraded as suggested in the theme upgrade guide. The markup isn't standards compliant and there are even some nesting issues with it.
Please don't get me wrong - it's a nice theme, looking beautifully. However, it's not a good example to promote right-handed menus, which was my initial point of interest.
I have added the fixed version (not all open issues fixed though) of the oranje theme for a default coppermine install without the modpack to the Demo and Download section. Maybe you could look into the theme once more and try to make it a "true" cpg1.4.x theme.
Logged

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 6006
Re: Oranje theme
« Reply #4 on: February 06, 2006, 09:48:22 am »

right, it's a 1.3 port. I've changed the menu system to use cpg1.4 standards. Will look into the markup later and upload then a new version
Logged
my CPG sandbox: Version 1.4.18 with modpack running my Tentacle theme:
http://stramm.st.funpic.org/

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 6006
Re: Oranje theme
« Reply #5 on: February 07, 2006, 04:25:16 pm »

I've updated both zips (modpack and unmodded 1.4.3). The modpack is W3C compliant for index, thumblist and image display. Therefore you need to use trhe latest modpack version

The standard version has to live with a few errors in image display (these can't be fixed in the theme.php but only in themes.inc.php / functions.inc.php)
Logged
my CPG sandbox: Version 1.4.18 with modpack running my Tentacle theme:
http://stramm.st.funpic.org/

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Oranje theme
« Reply #6 on: February 07, 2006, 11:48:20 pm »

it's a pity you didn't have a look at the changes I made to your package using a diff viewer, you would have noticed at least one mandatory thing that your standalone theme is lacking. Can't replace the demo version nor the download version with your new one, sorry.
Logged

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 6006
Re: Oranje theme
« Reply #7 on: February 08, 2006, 08:41:15 am »

it's a pity you didn't have a look at the changes I made to your package using a diff viewer, you would have noticed at least one mandatory thing that your standalone theme is lacking. Can't replace the demo version nor the download version with your new one, sorry.

I did... however somehow a bunch of tabs and linebreaks changed in your version. And cause I've rewritten every var and function in the meanwhile it's now ridiculous to diff view mine and your version.

If it's just the custom header you could just have said so.
Logged
my CPG sandbox: Version 1.4.18 with modpack running my Tentacle theme:
http://stramm.st.funpic.org/

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Oranje theme
« Reply #8 on: February 08, 2006, 09:09:41 am »

yes, alll tokens in curly braces must be present, especially the custom header, as we need it for the navigation on the demo.
Logged

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 6006
Re: Oranje theme
« Reply #9 on: February 08, 2006, 02:50:54 pm »

thanks, I made sure the new custom header/ footer, vanity, ip, report (comment/ image) work
Logged
my CPG sandbox: Version 1.4.18 with modpack running my Tentacle theme:
http://stramm.st.funpic.org/

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Oranje theme
« Reply #10 on: February 12, 2006, 11:17:52 am »

Thanks for looking into this - demo and download updated, above links are still valid.
Logged

n3n

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Posts: 173
Re: Oranje theme
« Reply #11 on: February 20, 2006, 09:31:52 pm »

Hi Stramm,

I seem to have some problems with the report to admin function. It only appears when using coppermine in a bridged mode..

Did you ever see this problem before ?
Logged

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 6006
Re: Oranje theme
« Reply #12 on: February 21, 2006, 10:55:49 am »

I do not use a bridged cpg... so I can't confirm. Can you give me a few more details/ description of the problem. Then I might be able to fix it
Logged
my CPG sandbox: Version 1.4.18 with modpack running my Tentacle theme:
http://stramm.st.funpic.org/

n3n

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Posts: 173
Re: Oranje theme
« Reply #13 on: March 01, 2006, 03:34:54 am »

Hi, i switched back to a standalone coppermine. The bridge didnt work very stable. Thanks for the help though.

I was wondering, i remove the text and stuff above the intermediate image, but now i have alot of space left on top of the
next/previous buttons. How can i remove this space, cant seem to find it in the css of theme.php.

Logged

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 6006
Re: Oranje theme
« Reply #14 on: March 01, 2006, 08:17:06 am »

If you modified the theme everything can be the reason. Do you have a link?
Logged
my CPG sandbox: Version 1.4.18 with modpack running my Tentacle theme:
http://stramm.st.funpic.org/

n3n

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Posts: 173
Re: Oranje theme
« Reply #15 on: March 01, 2006, 01:55:58 pm »

http://www.grafflix.org/flix/displayimage.php?album=lastup&cat=-1&pos=0

I put the report to admin/info link in the draggable box.
Logged

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 6006
Re: Oranje theme
« Reply #16 on: March 01, 2006, 02:36:05 pm »

looks to me like that's not just 'left space' but that's the place where the div is located your js makes movable
Logged
my CPG sandbox: Version 1.4.18 with modpack running my Tentacle theme:
http://stramm.st.funpic.org/

n3n

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Posts: 173
Re: Oranje theme
« Reply #17 on: March 01, 2006, 03:59:52 pm »

Hmm, i checked it with the firefox webdevelop plugin. It says its the #thumbs div. Should i try sending you my theme.php file ? Perhaps that would help.
Logged

n3n

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Posts: 173
Re: Oranje theme
« Reply #18 on: March 02, 2006, 01:49:14 pm »

any other ideas ?
Logged

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 6006
Re: Oranje theme
« Reply #19 on: March 03, 2006, 09:05:34 am »

looks to me like that's not just 'left space' but that's the place where the div is located your js makes movable
Logged
my CPG sandbox: Version 1.4.18 with modpack running my Tentacle theme:
http://stramm.st.funpic.org/
Pages: [1] 2 3   Go Up
 

Page created in 0.02 seconds with 20 queries.